Repository navigation
Fix offline detection_time offset by one inference step - #548
Merged
Merged
Conversation
The offline Postprocessor's t0 omitted the 1 / inference_sampling_rate term that online get_time_offset includes, so offline detection times came out one inference step (0.25 s at 4 Hz) early.
wbenoit26
approved these changes
Oct 5, 2026
wbenoit26
left a comment
wbenoit26
left a comment
Contributor
There was a problem hiding this comment.
Thanks for catching this!
Contributor
|
Oh, looks like we had a test based on the wrong offset. Could you fix that as well? |
Author
|
Yeah, I am working on that |
Author
|
I think it should be good now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The offline Postprocessor's t0 omitted the 1 / inference_sampling_rate term that online get_time_offset includes, so offline detection times came out one inference step (0.25 s at 4 Hz) early.