Rage Fighter Master Tree Finishup by ze-dom · Pull Request #866 · MUnique/OpenMU

ze-dom · 2026-08-06T16:09:56Z

To-do

Comment changes with sources
UpdatePlugin

Developments

Added master skill extra mana consumption depending on skill level
Added the magic effects: IncreaseBlockPowerUp, IncreaseBlockMastery, IncreaseHealthStrengthener
Added effects/target attributes for the RF master skills: DefSuccessRateIncPowUp, EquippedWeaponMastery, DefSuccessRateIncMastery, StaminaIncreaseStrengthener, DecreaseMana,

Bugfixes

On equipped weapon skills, no longer add the skill if a replacement master skill exists (existed previously, but only for RF weapons)
Fixed values/added caps for RF skills Increase Block, Increase Stamina and Ignore Defense

ze-dom · 2026-08-06T16:51:05Z

+            if (skillEntry?.Level > 0)
+            {
+                extraCost += (int)(attributeRequirement.MinimumValue * MasterSkillExtensions.CalculateManaRateValue(skillEntry.Level));
+            }


zTeamS6.3, emu

zTeamS6.3 does not have this, but the S6E3 client values also include this extra cost. Also, the function for it exists. E.g. (base mana requirement = 55):

ze-dom · 2026-08-06T16:53:58Z

 public static class MasterSkillExtensions
 {
+    private const string FormulaManaRateIncrease = "(2 + (((((((level - 30) ^ 3) + 25000) / 499) / 6)))) * 1.5";
+


ze-dom · 2026-08-06T20:24:13Z

+
        attributeRelationships.Add(this.CreateAttributeRelationship(Stats.MaximumHealth, 1, Stats.SwellLifeHealthIncrease, aggregateType: AggregateType.Multiplicate));
        attributeRelationships.Add(this.CreateAttributeRelationship(Stats.MaximumMana, 1, Stats.SwellLifeManaIncrease, aggregateType: AggregateType.Multiplicate));
+        attributeRelationships.Add(this.CreateAttributeRelationship(Stats.IncreaseBlockBonus, 1, Stats.DefenseRatePvm));


zTeamS6.3, emu
Though this only comes online for DefSuccessRateIncPowUp and DefSuccessRateIncMastery. That's why we start with a 0 value AggregateType.Multiplicate on IncreaseBlockEffectInitializer.cs

ze-dom · 2026-08-06T20:30:45Z

        result.AttributeCombinations.Add(this.CreateAttributeRelationship(Stats.ArcheryAttackMode, 1, Stats.IsBowEquipped));
        result.AttributeCombinations.Add(this.CreateAttributeRelationship(Stats.ArcheryAttackMode, 1, Stats.IsCrossBowEquipped));
        result.AttributeCombinations.Add(this.CreateAttributeRelationship(Stats.MeleeAttackMode, 0, Stats.ArcheryAttackMode, InputOperator.ExponentiateByAttribute));
+        result.AttributeCombinations.Add(this.CreateAttributeRelationship(Stats.SkillExtraManaCost, 0, Stats.AmmunitionConsumptionRate, InputOperator.ExponentiateByAttribute, AggregateType.Multiplicate));


If InfiniteArrow effect is active (Stats.AmmunitionConsumptionRate = 0), so will Stats.SkillExtraManaCost. Otherwise, it's 0.

ze-dom · 2026-08-06T20:33:00Z

-        var addExtraManaCost = this.Attributes![Stats.AmmunitionConsumptionRate] == 0
-            && skill.SkillType is SkillType.DirectHit or SkillType.AreaSkillAutomaticHits;


Replaced this with skill attributes for the elf's shooting skills on SkillsInitializer.cs.

ze-dom · 2026-08-06T20:37:06Z

ze-dom · 2026-08-06T20:38:17Z

BuffSkillEffect.xml: emu

ObjUseSkill.cpp: zTeamS6.3, emu
BuffEffect.cpp: zTeamS6.3, emu

The client actually applies it as a multiplier (verified on S6E3 official client). My guess is that it is a bug and the server sources are correct. Otherwise at max value (~1k energy) this would double the defense rate of the buff targets, which seems too much to me.

ze-dom · 2026-08-06T21:01:23Z

BuffSkillEffect.xml: emu

MasterLevelSkillTreeSystem.cpp: zTeamS6.3,, emu

ze-dom · 2026-08-06T21:03:10Z

BuffSkillEffect.xml: emu

MasterLevelSkillTreeSystem.cpp: zTeamS6.3, emu

ze-dom · 2026-08-06T21:06:55Z

BuffSkillEffect.xml: emu

ObjUseSkill.cpp: zTeamS6.3, emu

ze-dom · 2026-08-06T21:09:29Z

BuffSkillEffect.xml: emu

MasterLevelSkillTreeSystem.cpp: zTeamS6.3, emu

ze-dom · 2026-08-06T21:12:12Z

        this.CreateSkill(SkillNumber.FireScream, "Fire Scream", CharacterClasses.AllLords, DamageType.Physical, 130, 6, 10, 45, energyRequirement: 70, leadershipRequirement: 150, skillType: SkillType.AreaSkillAutomaticHits);
        this.AddAreaSkillSettings(SkillNumber.FireScream, true, 2f, 3f, 6f);
-        this.CreateSkill(SkillNumber.Explosion79, "Explosion", CharacterClasses.AllLords, DamageType.Physical, distance: 2);
+        this.CreateSkill(SkillNumber.Explosion79, "Explosion", CharacterClasses.None, DamageType.Physical, distance: 2);


This is the FireScream's explosion effect. It's not a castable skill. Everything was working previously, I just found out that CharacterClasses.None existed 😁 , so using it to simplify.

ze-dom · 2026-08-06T21:17:30Z

        this.CreateSkill(SkillNumber.ChaoticDiseier, "Chaotic Diseier", CharacterClasses.AllLords, DamageType.Physical, 190, 6, 15, 50, 100, 16, skillType: SkillType.AreaSkillAutomaticHits);
        this.AddAreaSkillSettings(SkillNumber.ChaoticDiseier, true, 1.5f, 1.5f, 6f, minimumHitsPerAttack: 7);
-        this.CreateSkill(SkillNumber.DoppelgangerSelfExplosion, "Doppelganger Self Explosion", CharacterClasses.AllMGs, DamageType.Wizardry, 140, 3, 25, 20, 100, elementalModifier: ElementalType.Fire);
+        this.CreateSkill(SkillNumber.DoppelgangerSelfExplosion, "Doppelganger Self Explosion", CharacterClasses.None, DamageType.Wizardry, 140, 3, 25, 20, 100, elementalModifier: ElementalType.Fire);


This is the Doppelganger mob's attack (attacktype="239").
Not a castable skill:

ze-dom · 2026-08-07T09:51:33Z

+    /// The increase health (stamina) strengthener effect of the rage fighter.
+    /// </summary>
+    IncreaseHealthStrengthener = 155,
+


ze-dom · 2026-08-07T09:53:23Z

-        this.AddMasterSkillDefinition(SkillNumber.DefSuccessRateIncMastery, SkillNumber.DefSuccessRateIncPowUp, SkillNumber.Undefined, 3, 3, SkillNumber.IncreaseBlock, 20, Formula502);
-        this.AddMasterSkillDefinition(SkillNumber.StaminaIncreaseStrengthener, SkillNumber.IncreaseHealth, SkillNumber.Undefined, 3, 4, SkillNumber.IncreaseHealth, 20, Formula1154);
-        this.AddMasterSkillDefinition(SkillNumber.DecreaseMana, SkillNumber.Undefined, SkillNumber.Undefined, 3, 4, SkillNumber.Undefined, 20, Formula722);
+        this.AddMasterSkillDefinition(SkillNumber.DefSuccessRateIncPowUp, SkillNumber.IncreaseBlock, SkillNumber.Undefined, 3, 2, SkillNumber.IncreaseBlock, 20, $"{Formula502} / 100", Formula502, Stats.IncreaseBlockBonus, AggregateType.Multiplicate);


ze-dom · 2026-08-07T09:53:49Z

-        this.AddMasterSkillDefinition(SkillNumber.StaminaIncreaseStrengthener, SkillNumber.IncreaseHealth, SkillNumber.Undefined, 3, 4, SkillNumber.IncreaseHealth, 20, Formula1154);
-        this.AddMasterSkillDefinition(SkillNumber.DecreaseMana, SkillNumber.Undefined, SkillNumber.Undefined, 3, 4, SkillNumber.Undefined, 20, Formula722);
+        this.AddMasterSkillDefinition(SkillNumber.DefSuccessRateIncPowUp, SkillNumber.IncreaseBlock, SkillNumber.Undefined, 3, 2, SkillNumber.IncreaseBlock, 20, $"{Formula502} / 100", Formula502, Stats.IncreaseBlockBonus, AggregateType.Multiplicate);
+        this.AddPassiveMasterSkillDefinition(SkillNumber.EquippedWeaponMastery, Stats.GloveWeaponMasteryDoubleDamageChance, AggregateType.AddRaw, Formula120Value, Formula120, 3, 3, SkillNumber.EquippedWeaponStrengthener);


ze-dom · 2026-08-07T09:54:57Z

-        this.AddMasterSkillDefinition(SkillNumber.DecreaseMana, SkillNumber.Undefined, SkillNumber.Undefined, 3, 4, SkillNumber.Undefined, 20, Formula722);
+        this.AddMasterSkillDefinition(SkillNumber.DefSuccessRateIncPowUp, SkillNumber.IncreaseBlock, SkillNumber.Undefined, 3, 2, SkillNumber.IncreaseBlock, 20, $"{Formula502} / 100", Formula502, Stats.IncreaseBlockBonus, AggregateType.Multiplicate);
+        this.AddPassiveMasterSkillDefinition(SkillNumber.EquippedWeaponMastery, Stats.GloveWeaponMasteryDoubleDamageChance, AggregateType.AddRaw, Formula120Value, Formula120, 3, 3, SkillNumber.EquippedWeaponStrengthener);
+        this.AddMasterSkillDefinition(SkillNumber.DefSuccessRateIncMastery, SkillNumber.DefSuccessRateIncPowUp, SkillNumber.Undefined, 3, 3, SkillNumber.DefSuccessRateIncPowUp, 20, Formula502, Formula502, Stats.DefenseFinal, AggregateType.AddFinal);


Tooltip innacurate/misleading - it adds defense.

ze-dom · 2026-08-07T09:55:26Z

+        this.AddMasterSkillDefinition(SkillNumber.DefSuccessRateIncPowUp, SkillNumber.IncreaseBlock, SkillNumber.Undefined, 3, 2, SkillNumber.IncreaseBlock, 20, $"{Formula502} / 100", Formula502, Stats.IncreaseBlockBonus, AggregateType.Multiplicate);
+        this.AddPassiveMasterSkillDefinition(SkillNumber.EquippedWeaponMastery, Stats.GloveWeaponMasteryDoubleDamageChance, AggregateType.AddRaw, Formula120Value, Formula120, 3, 3, SkillNumber.EquippedWeaponStrengthener);
+        this.AddMasterSkillDefinition(SkillNumber.DefSuccessRateIncMastery, SkillNumber.DefSuccessRateIncPowUp, SkillNumber.Undefined, 3, 3, SkillNumber.DefSuccessRateIncPowUp, 20, Formula502, Formula502, Stats.DefenseFinal, AggregateType.AddFinal);
+        this.AddMasterSkillDefinition(SkillNumber.StaminaIncreaseStrengthener, SkillNumber.IncreaseHealth, SkillNumber.Undefined, 3, 4, SkillNumber.IncreaseHealth, 20, Formula1154, Formula1154, Stats.TotalVitality, AggregateType.AddFinal);


ze-dom · 2026-08-07T09:55:50Z

+        this.AddPassiveMasterSkillDefinition(SkillNumber.EquippedWeaponMastery, Stats.GloveWeaponMasteryDoubleDamageChance, AggregateType.AddRaw, Formula120Value, Formula120, 3, 3, SkillNumber.EquippedWeaponStrengthener);
+        this.AddMasterSkillDefinition(SkillNumber.DefSuccessRateIncMastery, SkillNumber.DefSuccessRateIncPowUp, SkillNumber.Undefined, 3, 3, SkillNumber.DefSuccessRateIncPowUp, 20, Formula502, Formula502, Stats.DefenseFinal, AggregateType.AddFinal);
+        this.AddMasterSkillDefinition(SkillNumber.StaminaIncreaseStrengthener, SkillNumber.IncreaseHealth, SkillNumber.Undefined, 3, 4, SkillNumber.IncreaseHealth, 20, Formula1154, Formula1154, Stats.TotalVitality, AggregateType.AddFinal);
+        this.AddPassiveMasterSkillDefinition(SkillNumber.DecreaseMana, Stats.ManaUsageReduction, AggregateType.AddRaw, Formula722Value, Formula722, 4, 3);


ze-dom added 4 commits August 6, 2026 15:52

First commit

141aea7

Renamed stat

2768ab7

Added contingency for skill requirements with null skill entry

8115bd9

Added null default value

b5d6d72

ze-dom commented Aug 6, 2026

View reviewed changes

Comment thread src/Persistence/Initialization/Skills/IgnoreDefenseEffectInitializer.cs

ze-dom Aug 6, 2026

Copy link
Copy Markdown

Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

emu

ze-dom commented Aug 6, 2026

View reviewed changes

ze-dom commented Aug 7, 2026

View reviewed changes

ze-dom added 2 commits August 7, 2026 12:38

Added update plugin

310a653

Fixed few issues

588b08e

		var addExtraManaCost = this.Attributes![Stats.AmmunitionConsumptionRate] == 0
		&& skill.SkillType is SkillType.DirectHit or SkillType.AreaSkillAutomaticHits;

Uh oh!

Conversation

ze-dom commented Aug 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ze-dom Aug 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ze-dom Aug 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ze-dom Aug 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ze-dom Aug 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

ze-dom commented Aug 6, 2026 •

edited

Loading

ze-dom Aug 6, 2026 •

edited

Loading

ze-dom Aug 6, 2026 •

edited

Loading

ze-dom Aug 6, 2026 •

edited

Loading

ze-dom Aug 6, 2026 •

edited

Loading