FMX.DisplayLink.Android and other

[OnePeople-source]

In code florence delphi,

if TOSVersion.Check(13) then
// Some head units report release 13/14 while actually providing API 29.
// VsyncCallback exists only from API 33; use the same choice for the full lifetime.
We need check SDK_INT
FUseVsyncCallback := TJBuild_VERSION.JavaClass.SDK_INT >= 33;
if FUseVsyncCallback then
This verification method is found in several other places in Delphi, and it is not correct.

[stephane128]

Hi, can you confirm exactly which device report shows TOSVersion.Check(13) = true while using API 29? This is a serious issue for us, so we need to understand how this combination is possible.

[OnePeople-source]

Hi, can you confirm exactly which device report shows TOSVersion.Check(13) = true while using API 29? This is a serious issue for us, so we need to understand how this combination is possible.

Hi, this car units, ts10, ts18 and other, i dont know smartphones.

[Zeus64]

That a big problem because we use everywhere TOSVersion.Check(xx).
If the phone is bad and report a wrong API that not correspond to the system that normal that some app crash on it

[OnePeople-source]

That a big problem because we use everywhere TOSVersion.Check(xx). If the phone is bad and report a wrong API that not correspond to the system that normal that some app crash on it

They won't even launch, as the app crashes immediately—even before initialization—because DisplayLink is invoked very early on. Therefore, you simply need to replace the checks everywhere with TJBuild_VERSION.JavaClass.SDK_INT; that method is reliable.

[stephane128]

yes but replacing the check everywhere by TJBuild_VERSION.JavaClass.SDK_INT is not very simple because the code source of delphi also use TOSVersion everywhere, and we need to do this only for broken device :(

[OnePeople-source]

yes but replacing the check everywhere by TJBuild_VERSION.JavaClass.SDK_INT is not very simple because the code source of delphi also use TOSVersion everywhere, and we need to do this only for broken device :(

Embarcadero themselves need to make changes here; the implementation based on version checking is flawed, since in 90% of cases, after the check, you end up calling a version-specific API. But that’s just my opinion.