feat(errors): show comment and PR activity on the issues overview - #674
Merged
Conversation
Each issue row now carries activity rollups — comment count (including agent notes) and linked-PR counts by state — hydrated in one batched GROUP BY per page alongside the existing open-incident batch, and surfaced as a muted Activity lane on the errors list. Closed-unmerged PRs are treated as abandoned and counted by neither field, so a merged fix and an open attempt read differently at a glance while a row nobody has touched stays empty.
…the iOS spec The v2 contract test and the web adapter test build their own wire fixtures, and the iOS OpenAPI spec is generated from the v2 schemas — all three needed the comment/PR rollup fields added in the previous commit.
The generated client requires comment_count / open_pull_request_count / merged_pull_request_count, so the hand-written wire fixtures must carry them like the server does.
The generated ErrorIssue/ErrorIssueDetail initializers gained required commentCount/openPullRequestCount/mergedPullRequestCount params; the fixture builder defaults them to zero and gives the in-progress issue some visible activity.
🍁 Maple PR previewWarning Preview cleanup could not be confirmed. The Alchemy teardown outcome was Final commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The errors overview now shows per-issue activity at a glance: a new muted Activity lane on each row with the issue's comment count and its linked pull requests (count + open/merged state, via tooltip). A row nobody has touched stays empty rather than showing zeros, so severity and the incident chip remain the only eye-pulling marks.
How
ErrorIssueDocumentgainscommentCount,openPullRequestCount,mergedPullRequestCount; the v2 wire gains the snake_case twins, so the public API and MCP consumers get them too. Comment count includes agent notes. Closed-unmerged PRs are treated as abandoned and counted by neither PR field — a merged fix and an open attempt read differently, an abandoned one doesn't light up the row.hydrateIssueRowsruns two extra batchedGROUP BY issue_idqueries (timeline events filtered tocomment/agent_note, and PR links by state), both over existing(org_id, issue_id)indexes, mirroring the open-incident batch. Every list page and mutation response flows through this one seam, so v1, v2, and MCP all pick the fields up.ErrorSignalview-model into a newLANE.activityinerror-signal-row.tsx(header label stays in sync via the shared lane map). NewChatBubbleIconin the house segment style; the PR mark reusesBranchForkIcon.Review notes
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.