fix(web): stop the self-hosted ingestion UI throwing on a Clerk hook - #724
Merged
Makisuo merged 1 commit intoSep 1, 2026
Conversation
`useGuidedFramework` called Clerk's `useAuth()` unconditionally. `main.tsx` mounts `ClerkProvider` only when `isClerkAuthEnabled`, and the hook throws without one, so self-hosted `/settings` — which opens on the ingestion tab — and the dashboard setup checklist both failed to render instead of showing the ingestion configuration. The variant is now chosen at module scope off the build-time constant, the same shape `useOrganizationFeatureFlags` uses and for the reason documented there: an early return inside the hook runs after `useAuth()` has already thrown. The self-hosted build keeps its selection under the default key, having one org.
Makisuo
force-pushed
the
fix/04-self-hosted-ingestion-ui
branch
from
September 1, 2026 14:51
256bac6 to
2e3332e
Compare
🍁 Maple PR previewWarning Preview cleanup could not be confirmed. The Alchemy teardown outcome was Final commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fourth of a five-PR stack, based on #723.
useGuidedFrameworkcalled Clerk'suseAuth()unconditionally.main.tsxmountsClerkProvideronly whenisClerkAuthEnabled, and the hook throws without one, so on a self-hosted build both/settings, which opens on the ingestion tab, andfailed to render instead of showing the ingestion configuration.
settings-nav.tsxdoes not filter the ingestion tab for self-hosted, so it is the landing page.The variant is chosen at module scope off the build-time constant — the shape
useOrganizationFeatureFlagsalready uses, and for the reason documented there: an early return inside the hook runs afteruseAuth()has already thrown. The self-hosted build keeps its selection under the default key, having one org.Tests
A case added to
guided-setup.test.tsxrenders the hook with no provider — the exact production crash, verified to reproduce against the old code. It sits alongside the existing replay-privacy test in that file, which is untouched.