Repository navigation
fix(video): adapt portrait subtitles and source intro layouts - #26
Merged
Merged
Conversation
Update fixed-canvas test expectations to follow the requested video aspect ratio; retain exact 16:9 layout coverage.
Remove the Chinese word-boundary regression cases because the user explicitly requested removal of dictionary-based wrapping. Preserve approved portrait layout, intro, colors, watermark, and phrase segmentation.
Mapleeeeeeeeeee
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Portrait videos now use aspect-ratio-aware subtitle placement, compact bilingual spacing, and balanced wrapping. Long source cues are split at conservative phrase boundaries before translation; edited subtitle timings are preserved when burning.
The source intro card keeps its original wording, colors, attribution, and animation, while fitting long titles and URLs to portrait frames. Existing landscape styling and the source watermark remain intact. No jieba or CKIP dependency is included.
This branch also includes the earlier CJK translation-boundary edge-case fixes.
Validation: the current PR head passed the CI workflow, including lint/type checks, unit tests, integration tests, security scan, and E2E tests. Dependency Review cannot run because dependency graph support is unavailable on this repository; this is the same repository-level error seen on prior PRs.