Normalize PlanTaskType capability values - #2153
Merged
Merged
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
SCREENPlanTaskType_SCREENPlanTaskTypeEnum_SCREENPlanTaskType.SCREENTwinManagerConfigstartup loading use the sharedPlanTaskType.fromConfigurationValue(...)parserPlanTaskType_SCREENStartup configuration fix
TwinManagerConfigpreviously stripped onlyPlanTaskTypeEnum_before callingPlanTaskType.valueOf(...). A configured value such asPlanTaskType_SCREENtherefore reachedvalueOf(...)unchanged and prevented the server from starting.The startup parser now delegates to the shared parser, so all three forms load correctly:
SCREENPlanTaskType_SCREENPlanTaskTypeEnum_SCREENTests
PlanTaskType_values parse through GsonPlanTaskTypeEnum_values parse through GsonTwinManagerConfig(ConfigurationProperties)startup pathCoordination
The adapter branch adds a per-session Gson factory. Its
planTaskTypeEnumPrefixsetting can override the outbound representation for that codec without changing the shared configuration enum or leaking state between sessions:false->PlanTaskType_SCREENtrue->PlanTaskTypeEnum_SCREENThe coordinated adapter workflow installs this server branch and runs both
PlanTaskTypeTestandTwinManagerConfigPlanTaskTypeTestbefore compiling the adapter.