Skip to content

Release script plain ruby fixes - #8086

Open
Naragod wants to merge 2 commits into
masterfrom
release_script_plain_ruby_fixes
Open

Release script plain ruby fixes#8086
Naragod wants to merge 2 commits into
masterfrom
release_script_plain_ruby_fixes

Conversation

@Naragod

@Naragod Naragod commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Proposed Changes 🐛 Bug fix

The release/* scripts crash when run outside Rails. This PR converts them to plain Ruby so they run, and exempts release/ from rubocop check to prevent reintroducing the crash.

The scripts run as standalone ruby. The cherry-pick loop and the release playbook invoke them without Rails. They call ActiveSupport methods that load with Rails:

  • pluck / index_by
  • present?
  • Time.zone.parse
  • String#exclude?

Under plain ruby, each raises NoMethodError. Master's recon.rb dies with undefined method 'present?' for an instance of String. Rubocop masks this. The repo runs rubocop-rails, whose cops prefer those methods. Rails/Pluck demands pluck. Rails/NegateInclude demands .exclude?. The scripts pass lint and crash at runtime.

Screenshots of your changes (if applicable)

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue) X
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
📖 Documentation update (change that updates documentation)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • If this is my first contribution, I have added myself to the list of contributors.

After opening your pull request:

  • I have updated the project Changelog (this is required for all changes).
  • I have verified that the pre-commit.ci checks have passed.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

@coveralls

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 30307082867

Coverage remained the same at 90.467%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 51487
Covered Lines: 47607
Line Coverage: 92.46%
Relevant Branches: 2484
Covered Branches: 1219
Branch Coverage: 49.07%
Branches in Coverage %: Yes
Coverage Strength: 128.23 hits per line

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants