Add GitHub Actions CI and CMake build support - #6
Merged
Conversation
Two builds on each push/tag: Linux via a Docker container (Ubuntu 24.04, Qt6, Ninja) and Windows via MSVC 2022 / Qt 6.8 with windeployqt6. A release job uploads both archives when a version tag is pushed. Adds waller.pro MSVC flag conditionals (/W4 /arch:SSE4.1 /MP) so the project compiles with both MSVC and GCC/Clang from the same .pro file.
Add editor/CMakeLists.txt alongside waller.pro (both remain usable). CMake handles AUTOMOC/AUTOUIC/AUTORCC, links Qt6 SpatialAudio, and applies the same MSVC / GCC-Clang flag split as the updated .pro file. The editor source directory is added explicitly to the include search path to match qmake's implicit behaviour and satisfy AUTOMOC. CI configure steps updated to cmake -B build -S editor.
Avoids the chicken-and-egg problem where the CI image must exist before the first CI run. The build-ci-image.yml is kept for future use if a cached image becomes worth maintaining.
cpuid.h is GCC/Clang only; guard with _MSC_VER and use <intrin.h> with MSVC's __cpuid(int[4], level) signature instead. /arch:SSE4.1 is not recognised on MSVC x64 (SSE4 intrinsics are always available there without a flag); remove from CMakeLists.txt and waller.pro.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build-ci-image.yml)editor/CMakeLists.txtalongsidewaller.pro— both remain usable (Qt Creator can open either)editor/waller.prowith MSVC / GCC-Clang conditional flags so the project compiles with both toolchainsTest plan
v*tag and verify both release archives are attached to the GitHub releaseeditor/CMakeLists.txtand builds locally