fix: render text macros in pspicture labels - #36
Merged
Conversation
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
\rput(1.5,1){\LaTeX}rendered the literal string\LaTeXinstead of the logo — visible on mathapedia's How it works diagram, which the old site rendered correctly. Labels were stored as raw source (text: m[3]) and handed to MathJax verbatim; MathJax only touches delimited math, so a bare\LaTeXsurvives as text. Prose doesn't have the problem because the parser runs the Text transforms over it, and those map\LaTeX→$\LaTeX$.So labels now get the same Text pass as prose — not a
\LaTeXspecial case, so{\bf ...},''``,---etc. work in labels too.The catch is that a label often is math, and the transforms must not touch it:
--inside$...$means two minus signs, and rewriting it to–feeds MathJax broken input (there's a test pinning exactly that, from when this last regressed).parseLabeltherefore splits on$...$spans and transforms only the text between them, reassembling math byte-for-byte:parseText(prose) is unchanged — it keeps calling the transforms over the whole line, now via the extractedparseTextTransforms.rputgroup(an rput whose contents are shapes, not a label) is untouched.Verified by rendering mathapedia against these builds: the diagram label now matches the old site pixel-for-pixel. Full suite (591 tests, 10 projects) and the workspace build pass; the tracked browser bundle is regenerated.
Link to Devin session: https://app.devin.ai/sessions/e51e8ecb94d241bd8d89e65e642c3e43
Requested by: @pyramation