fix: restore the quotation environment's inset - #38
Merged
Conversation
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
quotationlost its indent and 10pt size onceparagraphize()started wrapping text runs in<p class="para">: the environment opened with a<p>, andisBlockmatches a line starting with<p, so the opening tag was flushed as its own block and the quote body became a sibling paragraph. Rendered DOM before:Fix is to make it a real wrapper —
bq/eqemit<blockquote class="quotation">…</blockquote>— so the paragraphized lines nest inside it, with the CSS rule moved to the wrapper (same 15px inset /0 0 20pxmargin / 10pt as before, inherited by the innerp.para).That needs
isBlockto match closing tags too (<\/?(h[1-6]|ul|…)), otherwise a bare</blockquote>line gets swallowed into the following paragraph run. Side effect, and an improvement: theorem-style environments no longer emit their</div>inside the paragraph.Site-visible on mathapedia.com's quoted passages (e.g.
/books/31/sections/156/407) after a publish + dep bump.Link to Devin session: https://app.devin.ai/sessions/e51e8ecb94d241bd8d89e65e642c3e43
Requested by: @pyramation