Repository navigation
Fixing Azure provisioning pipeline - GH auth - #160
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes Azure provisioning pipeline authentication issues by enabling GitHub CLI to work properly in CI/CD environments. It adds support for skipping authentication checks when running in CI mode and ensures the GitHub Actions workflow authenticates the CLI before pushing secrets.
- Added
--cicommand-line argument to skip GitHub CLI authentication checks in CI environments - Updated Azure provisioning workflow to authenticate GitHub CLI using the workflow's
GITHUB_TOKEN - Modified script execution to use the
--ciflag for CI/CD compatibility
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/workflows/azure-provision.yml |
Adds GitHub CLI authentication step and passes --ci flag to the secrets script |
.azure/scripts/push-info-to-gh-secrets.sh |
Implements command-line argument parsing and conditional authentication logic |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to the process of pushing Azure credentials to GitHub secrets, specifically enhancing support for CI/CD environments. The main changes include adding a command-line argument to skip GitHub CLI authentication in CI, updating the workflow to use this feature, and ensuring authentication is handled correctly in CI jobs.
CI/CD workflow improvements:
--cicommand-line argument in.azure/scripts/push-info-to-gh-secrets.shto skip GitHub CLI authentication checks when running in CI/CD environments..azure/scripts/push-info-to-gh-secrets.shto conditionally skip thegh auth statuscheck if running in CI mode, and display an appropriate message.GitHub Actions workflow updates:
.github/workflows/azure-provision.ymlto authenticate the GitHub CLI using the workflow'sGITHUB_TOKENbefore pushing secrets.--ciflag, ensuring compatibility with CI/CD environments.