Skip to content

Fixing Azure provisioning pipeline - GH auth - #160

Merged
MaxDac merged 3 commits into
mainfrom
maxdac/fix/fix-provisioning-pipeline-azure
Oct 1, 2025
Merged

MaxDac merged 3 commits into
mainfrom
maxdac/fix/fix-provisioning-pipeline-azure

Conversation

@MaxDac

@MaxDac MaxDac commented Oct 1, 2025

Copy link
Copy Markdown
Owner

This pull request introduces improvements to the process of pushing Azure credentials to GitHub secrets, specifically enhancing support for CI/CD environments. The main changes include adding a command-line argument to skip GitHub CLI authentication in CI, updating the workflow to use this feature, and ensuring authentication is handled correctly in CI jobs.

CI/CD workflow improvements:

  • Added support for a --ci command-line argument in .azure/scripts/push-info-to-gh-secrets.sh to skip GitHub CLI authentication checks when running in CI/CD environments.
  • Updated the authentication logic in .azure/scripts/push-info-to-gh-secrets.sh to conditionally skip the gh auth status check if running in CI mode, and display an appropriate message.

GitHub Actions workflow updates:

  • Modified .github/workflows/azure-provision.yml to authenticate the GitHub CLI using the workflow's GITHUB_TOKEN before pushing secrets.
  • Changed the workflow step that pushes Azure credentials to GitHub secrets to pass the --ci flag, ensuring compatibility with CI/CD environments.

@MaxDac
MaxDac requested a review from Copilot October 1, 2025 10:38

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes Azure provisioning pipeline authentication issues by enabling GitHub CLI to work properly in CI/CD environments. It adds support for skipping authentication checks when running in CI mode and ensures the GitHub Actions workflow authenticates the CLI before pushing secrets.

  • Added --ci command-line argument to skip GitHub CLI authentication checks in CI environments
  • Updated Azure provisioning workflow to authenticate GitHub CLI using the workflow's GITHUB_TOKEN
  • Modified script execution to use the --ci flag for CI/CD compatibility

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
.github/workflows/azure-provision.yml Adds GitHub CLI authentication step and passes --ci flag to the secrets script
.azure/scripts/push-info-to-gh-secrets.sh Implements command-line argument parsing and conditional authentication logic

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread .github/workflows/azure-provision.yml Outdated
Comment thread .azure/scripts/push-info-to-gh-secrets.sh Outdated
MaxDac and others added 2 commits October 1, 2025 11:40
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@MaxDac
MaxDac enabled auto-merge (squash) October 1, 2025 10:46
@MaxDac
MaxDac merged commit 75c7b68 into main Oct 1, 2025
3 checks passed
@MaxDac
MaxDac deleted the maxdac/fix/fix-provisioning-pipeline-azure branch October 1, 2025 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants