Conversation
We will use it to jump to the highlighted feature once we know the available area of the map that is not covered by the panel
- Use the renamed previewPanelHeight property instead of signal params
- Move all highlighting and form opening to a identifyFeature()
- Don't pan if whole feature is near visible map center - Center feature to visible map if it fits - Center clicked location to visible map if whole does not fit
- Add method to calculate the map extent required for a geometry to fit the visible part of the map canvas when covered by a drawer - Use animated zoom when identifying features from a list and not on map
Collaborator
|
might help resolve #3845 as well |
Withalion
reviewed
Aug 17, 2026
Withalion
left a comment
Withalion
left a comment
Collaborator
There was a problem hiding this comment.
Nice! It would be great to rebase on current master as well since some time passed.
| // Holds the map coordinates of the point the user identified. NaN if identify was triggered from list of features | ||
| property point identifyLocation: Qt.point(NaN, NaN) | ||
|
|
||
| signal featureIdentified( var pair, var point ) |
Collaborator
There was a problem hiding this comment.
Suggested change
| signal featureIdentified( var pair, var point ) | |
| signal featureIdentified( FeatureLayerPair pair, qgsPoint clickedPoint ) |
It's about time we expose FeatureLayerPair & QgsPoint to QML properly
Contributor
Author
There was a problem hiding this comment.
Well yes, but do you think this PR is the proper place to do it?
Collaborator
There was a problem hiding this comment.
QgsPoint is already exposed, I believe FeatureLayerPair can be exposed with just a few lines, so why not. You don't have to apply the refactoring everywhere just here is enough
| } | ||
| } | ||
|
|
||
| void TestUtilsFunctions::testDrawerCompensatedExtent() |
Collaborator
There was a problem hiding this comment.
As well here I would have case for:
- when the map is just panned
- when feature is bigger then current extent, so the map zooms out
- when feature is smaller then current extent
Contributor
Author
There was a problem hiding this comment.
This only tests the extent calculation when compensating for the drawer height.
Testing the actual panning to and zooming to would be a completely different case.
Collaborator
|
@uclaros can you please imrpove the description of this issue. What's happening, what's the issue. Mostly for testers to understand the issue better. |
📦 Build Artifacts Ready
|
Coverage Report for CI Build 36013951345Coverage increased (+0.1%) to 59.636%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions369 previously-covered lines in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
📦 Build Artifacts Ready
|
Withalion
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3845
This PR is a rework on how the map jumps to geometries.
Right now, a double animated pan happens is some cases while the feature form preview drawer is opening.
This is one thing handled by this PR: a single animation is performed while the drawer is opening.
The main change in behavior though is the following:
In all of the above the map canvas scale is unchanged and the pan is animated.
The advantages of this logic are that:
Identifying points or small geometries near the center of the (effective) screen does not modify the extent and the user does not need to re-orient himself (google maps does the same for POIs)
Scale is always preserved while navigating the map.
Identifying large geometries does not modify the map extent too much.
Testing notes: