Conversation
Coverage Report for CI Build 36397190567Coverage increased (+0.07%) to 59.581%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions23 previously-covered lines in 2 files lost coverage.
Coverage Stats
💛 - Coveralls |
📦 Build Artifacts Ready
|
|
Looks like it doesn't work for new features correctly: Screencast_20260904_161729.mp4The survey layer can link both photo and non-spatial layer. Non-spatial layer can also link photo layer. Non-spatial layer is set to be read only. It's possible to open the form of new feature for non-spatial layer, but impossible to save. When opening the for for non-spatial feature there is a visible switch between gallery and relation editor. |
📦 Build Artifacts Ready
|
📦 Build Artifacts Ready
|
Testing resultSetup: 
Scenario 1 — creating a new parent feature: ✅ Works as expected.
Scenario 2 — editing an existing parent feature: 🔴
Result: Partially fixed. The fix correctly hides the Add button for read-only child layers when creating a new parent feature, but the check is inconsistent when editing an existing parent feature — the Add button can still be triggered via the child feature list area, letting the user start creating a child feature that then cannot be saved. Screen_Recording_20260916_114918.mp4 |
c4b464c to
b2aa432
Compare
📦 Build Artifacts Ready
|
📦 Build Artifacts Ready
|
Re-testing note:Tested on: Result: Fixed. The read-only check now works the same way when creating a new parent feature and when editing an existing one. It's no longer possible to start creating a child feature that can't be saved. ✅Scenario 1 — creating a new parent feature: - Works as expected. ✅Scenario 2 — editing an existing parent feature: |
| // set layer early so it's known even before the parent feature has a valid id (e.g. new feature) | ||
| LayerFeaturesModel::setLayer( mRelation.isValid() ? mRelation.referencingLayer() : nullptr ); | ||
|
|
There was a problem hiding this comment.
Isn't this done directly within the setup method that is called on the line below?
4 participants
Description
The "add" button for relation-linked child features (photo gallery tiles and relation bubbles) was shown based only on the user's project role, without checking whether the underlying child layer itself was read-only. This allowed users to attempt adding features to layers that were explicitly configured as read-only in the QGIS project.
Fixes: #4640
What changed
Extended the visibility condition for the add button in
MMFormGalleryEditor.qmland the add relation button inMMFormRelationEditor.qmlto also checkrmodel.layer.readOnly, so the add button is hidden whenever the child layer is marked read-only, regardless of project role.Behavior
When the child layer is read-only, the add button is hidden and only existing linked child features remain visible. When the child layer is editable, the add button is shown as before (subject to the existing project role check). See attached screenshots for both editors, each with a read-only and non-read-only comparison alongside the corresponding QGIS layer settings.
Linked feature list - child layer
Photo gallery - child layer