Conversation
📦 Build Artifacts Ready
|
Contributor
Author
|
@Withalion @tomasMizera re-tests failed. Waiting for device. |
Collaborator
|
Okay let's close it then as it doesn't fix the issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On Android, confirming a value in certain text fields and closing the drawer could freeze the app and leave the screen only partially rendered. It showed up in a few places: changing the server during setup, GPS settings (antenna height, network provider), closing an account, and saving a feature form. The cause is that the text field still has active keyboard focus when the drawer starts closing, which leaves Qt's Android text input handling in a bad state.
What changed
Each affected drawer now clears focus from its text field(s) in
onAboutToHide, right before the drawer starts closing, instead of leaving it until after.Updated
MMLoginPage.qml(change server drawer),MMSettingsInput.qml(shared settings text input drawer, also used by GPS antenna height and accuracy tolerance),MMNetworkProviderDrawer.qml(IP/port/nickname drawer),MMCloseAccountDialog.qml(close account confirmation), andMMFormController.qml(feature form drawer).Behavior
Before, confirming or closing one of these drawers on Android could leave the screen half rendered and unresponsive until you tapped another field, or in the feature form case, force a full app restart.
After, focus is dropped before the drawer starts hiding, so the screen redraws properly on its own.