Skip to content

Bring back autotest with v2 sync API - #4729

Open
tomasMizera wants to merge 3 commits into
feature/sync-v2-decouple-selective-syncfrom
feature/sync-autotests-again
Open

tomasMizera wants to merge 3 commits into
feature/sync-v2-decouple-selective-syncfrom
feature/sync-autotests-again

Conversation

@tomasMizera

@tomasMizera tomasMizera commented Sep 29, 2026 •

Copy link
Copy Markdown
Collaborator

Autotests can now compile, run without crashing and mostly succeed. There are two more failing tests that need attention (one because we now consider "already on the latest version" a success and another of unknown reason).

Totals: 59 passed, 2 failed, 0 skipped, 0 blacklisted, 174374ms
********* Finished testing of TestMerginApi *********

The problems were of course not only in autotests - the fixes several problems in the code:

  • missing exit path when there is nothing to push
  • sync manager kept associating syncs that were not started via it, this caused duplicated connections and extra, undesired, runs of the sync loop

I commented out the test for push cancel as the logic is not implemented yet.

The PR can be reviewed and merged. The other two tests might need some more work.

@tomasMizera
tomasMizera added this pull request to stack #4730 September 29, 2026 20:54
@tomasMizera
tomasMizera marked this pull request as ready for review September 29, 2026 20:57
@tomasMizera
tomasMizera force-pushed the feature/sync-autotests-again branch from 482ea73 to b6ef25b Compare September 29, 2026 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant