Add CI to mimic qgis repo checks - #942
Merged
Merged
Conversation
MarcelGeo
approved these changes
Sep 16, 2026
harminius
force-pushed
the
qgis_repo_checks
branch
from
September 17, 2026 09:54
3eb8aee to
afbe92d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes CI reproduce the security and style scan that plugins.qgis.org runs on every upload, so we find out about a blocking finding on push instead of at release time.
We already had a
security_check.yml, but it did not reflect what the repository actually runs and could not fail on the things that matter:detect-secrets scanalways exits 0, including on files containing valid-format AWS keys and GitHub tokens. That step could never fail the build.-llrather than the repository's explicit test list, so it silently skipped checks qgis.org treats as blocking - hardcoded passwords (B105–B107) among them.pyproject.toml. The repository enables only 26 of 96 codes and never sees that file, so the local result and the upstream result were unrelated.How the upstream gate actually works
BLOCKEDBLOCKEDRules the administrators mark skippable still block unless the uploader ticks them on the upload form; mandatory rules cannot be waived at all.
What this adds
scripts/qgis_plugin_repo_rules.json— a pinned snapshot of all 205 rules from qgis/QGIS-Plugins-Websitescripts/qgis_plugin_repo_checks.py— runs the three tools with the same flags and rule selection the repository uses, classifies each finding as mandatory or skippable, and exits non-zero only on blocking mandatory findings..github/workflows/security_check.yml— rewritten to call the script, with tool versions pinnedScan scope mirrors the rsync filter in
packages.yml(test/,__pycache__/excluded), so we check what actually ships rather than what happens to be in the tree.Resolves https://github.com/MerginMaps/server-private/issues/3512