Skip to content

fix inconsistent error code - #684

Merged
MarcelGeo merged 1 commit into
developfrom
fix_inconsistent_error_code
Sep 29, 2026
Merged

MarcelGeo merged 1 commit into
developfrom
fix_inconsistent_error_code

Conversation

@varmar05

@varmar05 varmar05 commented Sep 29, 2026 •

Copy link
Copy Markdown
Collaborator

For existing version we must return ProjectVersionExists not an generic upload error.
Stale upload and processed tmp files should be removed as well.

For existing version we must return ProjectVersionExists not an generic upload error.
Stale upload and processed tmp files should be removed as well.
@varmar05
varmar05 requested a review from MarcelGeo September 29, 2026 08:23
@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 36542401963

Coverage increased (+0.02%) to 92.667%

Details

  • Coverage increased (+0.02%) from the base build.
  • Patch coverage: 8 of 8 lines across 2 files are fully covered (100%).
  • 1 coverage regression across 1 file.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

1 previously-covered line in 1 file lost coverage.

File Lines Losing Coverage Coverage
server/mergin/sync/public_api_v2_controller.py 1 89.35%

Coverage Stats

Coverage Status
Relevant Lines: 11155
Covered Lines: 10337
Line Coverage: 92.67%
Coverage Strength: 0.93 hits per line

💛 - Coveralls

@MarcelGeo
MarcelGeo merged commit 129040b into develop Sep 29, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants