List all unsupported file names in v2 push error - #691
Merged
Merged
Conversation
Coverage Report for CI Build 36997656905Coverage decreased (-0.03%) to 92.709%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions32 previously-covered lines in 6 files lost coverage.
Coverage Stats
💛 - Coveralls |
MarcelGeo
requested changes
Oct 2, 2026
| f"Unsupported file type detected: '{file_path}'. " | ||
| f"Please remove the file or try compressing it into a ZIP file before uploading.", | ||
| ) | ||
|
|
Collaborator
There was a problem hiding this comment.
Leave here that code and just raise specific error. Do not need specific loops. That can simplify this code.
like if diff and not is_valid_path():
raise UnsupportedFileName.
Contributor
Author
There was a problem hiding this comment.
Ok, I put the validation in the existing loop. But I need to raise the specific error only when the loop finishes.
MarcelGeo
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves https://github.com/MerginMaps/server-private/issues/3529
POST /v2/projects/{id}/versionsnow rejects unsupported file names with 422UnsupportedFilesDetectedand lists every offending path, diff paths included, inunsupported_files. Before, it returnedUploadErrornaming only the first file. This also applies tocheck_onlydry runs.The name check now runs over all files before the other per-file checks. v1 push keeps its 400 response, and its message now lists all files too.