Delete some over engineered slop - #77
Open
rsproule wants to merge 4 commits into
Open
Conversation
- swap the hand-rolled CDP WebSocket client in kernel-native-autofill for chrome-remote-interface, keeping only the per-command deadline and abort wiring - parse Chrome password CSVs with papaparse instead of a custom parser - consolidate all parsing of Eve's background-task notification strings into lib/eve-task-notifications.ts, used by the chat UI, the browser benchmark, and iMessage cancellation delivery Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012mnvvBKSjkKrggysY5CmWr
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012mnvvBKSjkKrggysY5CmWr
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012mnvvBKSjkKrggysY5CmWr
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012mnvvBKSjkKrggysY5CmWr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kernel-native-autofillforchrome-remote-interface; the wrapper keeps only the 15s per-command deadline and abort wiring, and the rest of the autofill engine is untouchedpapaparseinstead of the custom parserBackground task …notification strings intolib/eve-task-notifications.ts(chat UI, browser benchmark, iMessage cancellation delivery); the strings now live in exactly one fileNot changed, checked deliberately:
db/schema/auth.ts: diffed against Better Auth's generated schema — field-level parity confirmed; the file keeps camelCase physical columns (already applied by migrations), timezone-aware timestamps, and the extraaccount.issuercolumn, so adopting generator output would rename live columns for no benefitstep.completedevent, with no aggregate session API, so the summarizer is currently irreducible; the right fix is upstream typed delivery/usage events, same as for the notification stringsValidation
pnpm checkpnpm build🤖 Generated with Claude Code
https://claude.ai/code/session_012mnvvBKSjkKrggysY5CmWr