Repository navigation
fix: align checkboxes with their labels in HR forms - #375
Merged
Merged
Conversation
The shared web Checkbox centred its label text (button default) and the box against wrapped lines; the worker form also rendered Active and Logistics as inline siblings on one line at different heights. - Checkbox: top-align box, label line height equals box size, left-aligned text, min-w-0 so long labels wrap. - WorkerForm: stack Active / Logistics in a left-aligned column. - Worker/User skills matrix: let the skill label shrink and wrap. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Fifteen keys from earlier merges (log viewer, process segments, work order links) existed in en.json only, failing the i18n parity gate. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
`php artisan test` runs phpunit in a child process that ignores -d on the parent, so with PHP's default 128M the full suite crashes with out-of-memory errors (reproduced on the develop base). Setting it in phpunit.xml matches what .githooks/pre-commit already uses. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
# Conflicts: # CHANGELOG.md # backend/lang/pl.json
# Conflicts: # CHANGELOG.md
jakub-przepiora
added a commit
that referenced
this pull request
Oct 22, 2026
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one): 1
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jakub-przepiora
marked this pull request as ready for review
October 23, 2026 08:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Checkboxes in the HR forms were not level with their labels, and some sat side by side at
different heights.
of sitting side by side at different heights.
wraps on a narrow screen keeps the box on its first line and stays left-aligned instead of
centring under the box.
account form now wrap instead of pushing the skill-level dropdown off narrow screens.
Why
The shared
Checkboxcomponent centred its box and label vertically and didn't give thelabel a fixed line height, so a one-line label could sit slightly off from the box, and a
wrapped label re-centred itself under the box instead of staying aligned with it. The worker
form additionally laid two checkboxes out in a row, so they drifted apart whenever one label
wrapped before the other.
How it was verified
This is a CSS-only layout change with no new routes, inputs, or business logic, so no new
Laravel tests were added; the existing test suite covers these pages' other behavior
unchanged. Click-through demo recorded by an independent QA agent on a fresh instance — see
Demo below.
Review notes
Checkboxcomponent change affects every checkbox in core (55 uses across 27 files,plus the data table's small variant) because the fix lives in the shared component. All
existing labels are plain strings, so the new fixed line height cannot clip any markup.
PHPUnit memory limit to 1G (
backend/phpunit.xml) to match the pre-commit hook's suite run,and stopping tracking of committed Python bytecode under
.claude/skills(.gitignoreplustwo cleanup commits). Both are harmless but outside the scope of this fix.
layout classes); acceptable for a CSS-only change already covered by the click-through
demo and manual review.
Demo
Recorded by an independent QA agent clicking through a fresh instance (login → menu → change). No API calls, deep links or injected data — enforced by
demo-guard.mjs.Screenshots, step by step
after login
workers list
desktop new worker unchecked
desktop new worker toggled
worker created
desktop edit worker
desktop new account
desktop worker profile
mobile new account
mobile new worker
mobile new worker toggled
Screenshots and all evidence files