Skip to content

feat(i18n): update Vietnamese translations to match upstream develop - #378

Merged
jakub-przepiora merged 1 commit into
Mes-Open:developfrom
SoiBien-AI:feat/translate-develop
Oct 24, 2026
Merged

jakub-przepiora merged 1 commit into
Mes-Open:developfrom
SoiBien-AI:feat/translate-develop

Conversation

@SoiBien-AI

@SoiBien-AI SoiBien-AI commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Synchronizes with upstream develop branch.
  • Updates backend/lang/vi.json with 76 new Vietnamese manufacturing translations covering Quality Inspection & Dispositions, HR Worker Linking, Installation Currency & Cost Reports, and Admin View Templates.

Terminology Compliance

All translations strictly adhere to MES manufacturing standards:

  • Material → Vật liệu
  • Work Order → Lệnh sản xuất
  • Crew Leader → Trưởng nhóm / Tổ trưởng
  • Lot Sequence → Quy tắc đánh số lô
  • Pieces (pcs) → sp
  • Accept with deviation → Chấp nhận có sai lệch
  • Quality disposition → Quyết định xử lý chất lượng

Validation

  • ✅ JSON syntax valid for both backend/lang/vi.json and mobile/lang/vi.json
  • ✅ stillMissing = 0 for both backend and mobile locales
  • ✅ Formatted with 4-space indentation matching existing locale files

Summary by CodeRabbit

  • Localization
    • Added Vietnamese translations for output and status labels, currency and cost messages, worker-account linking, inspection results and dispositions, quality permissions, and inspection-plan validation.

@coderabbitai

coderabbitai Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between c9ebcb9 and 5729b16.

Files selected for processing: 1
  • backend/lang/vi.json

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

Walkthrough

The Vietnamese locale now includes translations for output and status labels, currency and cost messages, worker-account linking, inspection results and permissions, and inspection-plan validation.

Changes: Vietnamese localization

Layer / File(s) Summary
Vietnamese message translations
backend/lang/vi.json
Adds translations for output and status labels, currency and cost messages, worker-account linking, inspection results and dispositions, quality permissions, and inspection-plan validation. The existing Hide output translation is unchanged.

Priority: Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Feature

Possibly related PRs

  • Mes-Open/OpenMes#376: Adds English and Polish keys for view-template messages and open-pallet quantities that this PR translates into Vietnamese.

Suggested reviewers: jankolo04

Merge Risk: Minimal · up to 5729b

No merge-blocking risk was identified; the translation update is ready for normal checks.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely identifies the main change: updating Vietnamese translations to match upstream develop.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches: 💡 1
🛠️ Fix failing CI checks: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@SoiBien-AI

Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@SoiBien-AI

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 24, 2026 •

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@jakub-przepiora
jakub-przepiora merged commit 87226a3 into Mes-Open:develop Oct 24, 2026
2 of 3 checks passed
jakub-przepiora added a commit that referenced this pull request Oct 25, 2026
Resolve conflicts with develop's plant overview header (#379) and the
translation update (#378): keep both CHANGELOG entries; lang files merged
per key with the i18n-lang-files resolver (en/pl parity 7136/7136).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants