Repository navigation
CI: hash the build-mrbind action file into its cache key - #7123
Merged
Merged
Conversation
The cached build/ only keeps the executables the action lists and strips them, so a change to that list restored a stale cache without the new files. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
build-mrbindaction caches a trimmedbuild/directory: it deletes everything but the executables it lists (mrbind,mrbind_gen_c,mrbind_gen_csharp) and strips them. The cache key hashes only the build script, so a change to that list (adding an executable, as #7104 does) silently restores a stale cache that lacks the new file. This adds the action file itself to the key. One cache miss per job on the first run after merging, then as before.Split out of #7104 / #7115.
🤖 Generated with Claude Code