Repository navigation
Bump mrbind: shorter Java test output paths - #7162
Merged
Merged
Conversation
MeshInspector's Windows CI went over MAX_PATH checking out this submodule after mrbind#55 (177-char test output paths); now at most 141. The Java ffi class names are truncated like the other classes. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
thirdparty/mrbindto the head ofvibecodedwith MeshInspector/mrbind#59 merged.After #7115, MeshInspector's self-hosted Windows runners failed to check out this submodule with
Filename too long: the committed Java test outputs had paths up to 177 characters, and that runner's workspace prefix forMeshLib\thirdparty\mrbind\is 86, over the 260 limit (the Rust outputs were at 155). mrbind#59 truncates the Javafficlass names like the other classes (they are named after C files that the C generator already truncates at 100 plus a hash, so the Java limit never applied to them) and generates the test outputs with--max-class-name-length 64, longest path now 141. The default limit for MeshLib's own bindings stays 100.MeshInspector's CI also enables
core.longpathsfor that checkout since MeshInspector/MeshInspectorCode#7929, so this is about plain Windows clones.🤖 Generated with Claude Code