Repository navigation
Repeater nicknames for Top Heard and the Apple surfaces - #36
Merged
Merged
Conversation
…ty, watch and Siri
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Lets users give repeaters their own short names, so Top Heard can read "Mell 12.3" instead of "5007 12.3". This closes MeshMapper/MeshMapper_Project#557 (requested by F4VSJ, who keeps a paper list of hex IDs and names in the car).
How matching works
ExternalSurfaceGeoBuilder.resolveOverlayRow.Storage
user_preferencesHive box underrepeater_nicknames, as an untyped map. No new@HiveTypeand no server change._openBoxSafelydeletes the wholeuser_preferencesbox if it fails to open within 5 s. That would drop nicknames along with every other preference.UI
Testing
flutter analyze: no issues.flutter test: all 2490 pass, 1 skipped.labelForandresolveOverlayRow: unique, shared hash, identity disambiguation, empty hexIdbuildHeardand SiribuildRecentHeardwith nicknamesWiki: MeshMapper/MeshMapper_Wiki#40