Skip to content

shared git clone - #254

Merged
Yaswant Pradhan (yaswant) merged 5 commits into
MetOffice:mainfrom
james-bruten-mo:shared_clone
Sep 10, 2026
Merged

shared git clone#254
Yaswant Pradhan (yaswant) merged 5 commits into
MetOffice:mainfrom
james-bruten-mo:shared_clone

Conversation

@james-bruten-mo

@james-bruten-mo James Bruten (james-bruten-mo) commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator

PR Summary

Sci/Tech Reviewer:
Code Reviewer: Yaswant Pradhan (@yaswant)

Code Quality Checklist

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
  • Comments have been included that aid understanding and enhance the readability of the code
  • My changes generate no new warnings
  • All automated checks in the CI pipeline have completed successfully

Testing

  • This change has been tested appropriately (please describe)

Security Considerations

  • I have reviewed my changes for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

AI Assistance and Attribution

  • Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Sci/Tech Review

  • I understand this area of code and the changes being added
  • The proposed changes correspond to the pull request description
  • Documentation is sufficient (do documentation papers need updating)
  • Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

  • All dependencies have been resolved - No dependency
  • Related Issues have been properly linked and addressed - NA
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Security considerations have been addressed - None.
  • Performance impact is acceptable - Performance improved.

@github-actions github-actions Bot added the cla-required The CLA has not yet been signed by the author of this PR - added by GA label Sep 10, 2026
@github-actions github-actions Bot added cla-signed The CLA has been signed as part of this PR - added by GA and removed cla-required The CLA has not yet been signed by the author of this PR - added by GA labels Sep 10, 2026

@yaswant Yaswant Pradhan (yaswant) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks James Bruten (@james-bruten-mo)
I have a small suggestion: capture trace/performance output, as it can be helpful when debugging issues.

Comment thread nightly_testing/generate_test_suite_cron.py Outdated
Comment thread nightly_testing/tests/test_generate_test_suite_cron.py Outdated
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
@yaswant Yaswant Pradhan (yaswant) added this to the Autumn 2026 milestone Sep 10, 2026
@yaswant
Yaswant Pradhan (yaswant) merged commit d8135a2 into MetOffice:main Sep 10, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The CLA has been signed as part of this PR - added by GA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants