Activation fix

[iboutle]

PR Summary

Sci/Tech Reviewer: paulfield2024
Code Reviewer: Erica Neininger (@ericaneininger)

Fix for uninitialised values of dactive and dmass_d in activation.

Linked to MetOffice/lfric_apps#709 and MetOffice/um#117

N.B. submitted as a triple-linked change to make the dependencies clear. The Casim change will have no effect on the lfric_apps trunk as-is, but is a requirement for the lfric_apps ticket to function. So the Casim ticket could be committed and UM KGO updated, followed by the apps ticket being committed later.

Code Quality Checklist

(Some checks are automatically carried out via the CI pipeline)

• I have performed a self-review of my own code
• My code follows the project's style guidelines
• Comments have been included that aid understanding and enhance the readability of the code
• My changes generate no new warnings

Testing

• If shared files have been modified, I have run the UM and LFRic Apps rose
  stem suites
• If any tests fail (rose-stem or CI) the reason is understood and
  acceptable (eg. kgo changes)
• I have added tests to cover new functionality as appropriate (eg. system
  tests, unit tests, etc.)

trac.log

Security Considerations

• I have reviewed my changes for potential security issues
• Sensitive data is properly handled (if applicable)
• Authentication and authorisation are properly implemented (if applicable)

Performance Impact

• Performance of the code has been considered and, if applicable, suitable performance measurements have been conducted

AI Assistance and Attribution

• Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Documentation

• Where appropriate I have updated documentation related to this change and confirmed that it builds correctly

Sci/Tech Review

• I understand this area of code and the changes being added
• The proposed changes correspond to the pull request description
• Documentation is sufficient (do documentation papers need updating)
• Sufficient testing has been completed

Please alert the code reviewer via a tag when you have approved the SR

Code Review

• All dependencies have been resolved
• Related Issues have been properly linked and addressed
• CLA compliance has been confirmed
• Code quality standards have been met
• Tests are adequate and have passed
• Documentation is complete and accurate
• Security considerations have been addressed
• Performance impact is acceptable

[paulfield2024]

fixes a bug that allowed Nans to propagate

[Erica Neininger (ericaneininger)]

Line 153 is: dmass_d=0.0 - so I would dispute that it was previously uninitialised. I'm happy to relocate it to L265 though - since it's closer to where it is actually used, and the use of a parameter rather than 0.0 is preferred. Can we remove L153 though please?

L276-277 else statement is redundant.

[iboutle]

Line 153 is: dmass_d=0.0 - so I would dispute that it was previously uninitialised. I'm happy to relocate it to L265 though - since it's closer to where it is actually used, and the use of a parameter rather than 0.0 is preferred. Can we remove L153 though please?

L276-277 else statement is redundant.

I think L153 is needed, because L265 is within if-statements that don't always get executed. Presumably that means L265 isn't actually needed (I presume dactive is the thing that was uninitialised).

I've done this and removed the else statement in f2776f5

[Erica Neininger (ericaneininger)]

Thanks for these changes.