Skip to content

Fix JULES macro for Rivers-standalone compability #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Maggie (maggiehendry) wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix JULES macro for Rivers-standalone compability #175

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 35 additions & 21 deletions rose-meta/jules-standalone/versions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,24 +55,38 @@ class vn82_t141(MacroUpgrade):
def upgrade(self, config, meta_config=None):
"""Upgrade a JULES runtime app configuration."""

self.rename_setting(config, ["namelist:fire_switches"],
["namelist:jules_fire_weather_index"])
self.rename_setting(config, ["namelist:jules_fire_weather_index",
"l_fire"],
["namelist:jules_fire_weather_index",
"l_fire_weather_index"])

source = self.get_setting_value(config, ["file:fire.nml","source"])
source = source.replace("namelist:fire_switches",
"namelist:jules_fire_weather_index")
self.change_setting_value(config, ["file:fire.nml","source"], source)
lsm_id = int(
self.get_setting_value(
config, ["namelist:jules_model_environment", "lsm_id"]
)
)
if lsm_id != 3:
self.rename_setting(
config,
["namelist:fire_switches"],
["namelist:jules_fire_weather_index"],
)
self.rename_setting(
config,
["namelist:jules_fire_weather_index", "l_fire"],
["namelist:jules_fire_weather_index", "l_fire_weather_index"],
)
source = self.get_setting_value(
config, ["file:fire.nml", "source"]
)
source = source.replace(
"namelist:fire_switches", "namelist:jules_fire_weather_index"
)
self.change_setting_value(
config, ["file:fire.nml", "source"], source
)

return config, self.reports


class vn82_t155(MacroUpgrade):

"""Upgrade macro from JULES by Author"""
"""Upgrade macro from JULES by Maggie Hendry"""

BEFORE_TAG = "vn8.2_t141"
AFTER_TAG = "vn8.2_t155"
Expand Down Expand Up @@ -115,14 +129,14 @@ def upgrade(self, config, meta_config=None):
)
self.add_report(info=msg, is_warning=True)

jules_surface_types = {}
jules_surface_types["c3_crop_wheat"] = "0"
jules_surface_types["c3_crop_soybean"] = "0"
jules_surface_types["c4_crop_maize"] = "0"
jules_surface_types["c3_crop_rice"] = "0"
for item, value in jules_surface_types.items():
self.add_setting(
config, ["namelist:jules_surface_types", item], value
)
jules_surface_types = {}
jules_surface_types["c3_crop_wheat"] = "0"
jules_surface_types["c3_crop_soybean"] = "0"
jules_surface_types["c4_crop_maize"] = "0"
jules_surface_types["c3_crop_rice"] = "0"
for item, value in jules_surface_types.items():
self.add_setting(
config, ["namelist:jules_surface_types", item], value
)

return config, self.reports
Loading