Skip to content

Update PR template with AI attribution checks - #679

Open
Yaswant Pradhan (yaswant) wants to merge 2 commits into
MetOffice:mainfrom
yaswant:update-pr-template
Open

Yaswant Pradhan (yaswant) wants to merge 2 commits into
MetOffice:mainfrom
yaswant:update-pr-template

Conversation

@yaswant

@yaswant Yaswant Pradhan (yaswant) commented Jul 29, 2026 •

Copy link
Copy Markdown
Collaborator

PR Summary

Update PR template to clarify AI attributions

Sci/Tech Reviewer: James Penn (@jamesp)
Code Reviewer: James Bruten (@james-bruten-mo)

Code Quality Checklist

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
  • Comments have been included that aid understanding and enhance the readability of the code
  • My changes generate no new warnings
  • All automated checks in the CI pipeline have completed successfully

Testing

  • I have tested this change locally, using the LFRic Apps rose-stem suite
  • If any tests fail (rose-stem or CI) the reason is understood and acceptable (e.g. kgo changes)
  • I have added tests to cover new functionality as appropriate (e.g. system tests, unit tests, etc.)
  • Any new tests have been assigned an appropriate amount of compute resource and have been allocated to an appropriate testing group (i.e. the developer tests are for jobs which use a small amount of compute resource and complete in a matter of minutes)

trac.log

Security Considerations

  • I have reviewed my changes for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

Performance Impact

  • Performance of the code has been considered and, if applicable, suitable performance measurements have been conducted

AI Assistance and Attribution

  • Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Documentation

  • Where appropriate I have updated documentation related to this change and confirmed that it builds correctly

PSyclone Approval

  • If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel interface, optimisation scripts, LFRic data structure code) then please contact the TCD Team

Sci/Tech Review

  • I understand this area of code and the changes being added
  • The proposed changes correspond to the pull request description
  • Documentation is sufficient (do documentation papers need updating)
  • Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • CLA compliance has been confirmed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Documentation is complete and accurate
  • Security considerations have been addressed
  • Performance impact is acceptable

@t00sa
Sam Clarke-Green (t00sa) removed their request for review August 14, 2026 10:43
@tommbendall Thomas Bendall (tommbendall) mentioned this pull request Aug 17, 2026
18 of 28 tasks
@iboutle iboutle mentioned this pull request Aug 19, 2026
19 of 28 tasks
@iboutle iboutle mentioned this pull request Sep 10, 2026
20 of 28 tasks
*Only check the boxes below if they are true. If any box cannot be checked, your PR will be automatically rejected.*

## AI Assistance and Attribution
- [ ] **Indemnified Tool:** The tool used is an approved, enterprise/institutional tier model that provides IPR indemnity (e.g., *Met Office GitHub Copilot Enterprise*).

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An organisation may choose to make an exception to the requirement for use of a tool that is indemnified. With an appropriate level of scrutiny of the generated code, this may be acceptable, but the developer would then not be able to tick this box.

@iboutle iboutle mentioned this pull request Sep 11, 2026
18 of 28 tasks

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants