Cosp add diag

[Dr Stephan Havemann (Petzi1)]

PR Summary

Sci/Tech Reviewer: Alejandro Bodas (Alejandro Bodas (@mo-abodas))
Code Reviewer: Erica Neininger (@ericaneininger)

The changes in this PR are to add extra secondary COSP diagnostics. Where these are level dependent, the 40 COSP standard level set has been used:
2331 ISCCP WEIGHTED CLOUD ALBEDO
2333 ISCCP WEIGHTED CLOUD TOP PRESSURE
2334 ISCCP TOTAL CLOUD AREA
2340 CALIPSO MOLECULAR BACKSCATTER (Note this is output on driving (LFRic) model levels)
2354 GRIDBOX-MEAN CLOUDSAT Ze 40 LEVELS
2356 GRIDBOX-MEAN CALIPSO ATB 40 LEVELS
2357 CALIPSO MOLECULAR ATB 40 LEVELS
2359 (goes with 2327 for its MASK) CALIPSO/CLOUDSAT CLOUD 40 LEVELS
2371 CALIPSO CLOUD AREA 40 LEVELS
2372 CLOUDSAT CFAD Ze 40 LEVELS

• linked Cosp add diag socrates#40

Code Quality Checklist

• I have performed a self-review of my own code
• My code follows the project's style guidelines
• Comments have been included that aid understanding and enhance the readability of the code
• My changes generate no new warnings
• All automated checks in the CI pipeline have completed successfully

Testing

• I have tested this change locally, using the LFRic Apps rose-stem suite
• If any tests fail (rose-stem or CI) the reason is understood and acceptable (e.g. kgo changes)
• I have added tests to cover new functionality as appropriate (e.g. system tests, unit tests, etc.)
• Any new tests have been assigned an appropriate amount of compute resource and have been allocated to an appropriate testing group (i.e. the developer tests are for jobs which use a small amount of compute resource and complete in a matter of minutes)

trac.log

Security Considerations

• I have reviewed my changes for potential security issues
• Sensitive data is properly handled (if applicable)
• Authentication and authorisation are properly implemented (if applicable)

Performance Impact

• Performance of the code has been considered and, if applicable, suitable performance measurements have been conducted

AI Assistance and Attribution

• Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Documentation

• Where appropriate I have updated documentation related to this change and confirmed that it builds correctly

PSyclone Approval

• If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel interface, optimisation scripts, LFRic data structure code) then please contact the HPC Optimisation Team

Sci/Tech Review

• I understand this area of code and the changes being added
• The proposed changes correspond to the pull request description
• Documentation is sufficient (do documentation papers need updating)
• Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

• All dependencies have been resolved
• Related Issues have been properly linked and addressed
• CLA compliance has been confirmed
• Code quality standards have been met
• Tests are adequate and have passed
• Documentation is complete and accurate
• Security considerations have been addressed
• Performance impact is acceptable

[Alejandro Bodas (mo-abodas)]

Is this a 3D cloud fraction? then the units should be 1

[Dr Stephan Havemann (Petzi1)]

Thank you Alejandro. I have corrected this.

[Alejandro Bodas (mo-abodas)]

Units as in comment above.

[Dr Stephan Havemann (Petzi1)]

Thank you Alexandro. I have corrected these.

[Alejandro Bodas (mo-abodas)]

Please see comment above

[Dr Stephan Havemann (Petzi1)]

Thank you Alejandro. I have corrected this.

[Alejandro Bodas (mo-abodas)]

Please see comment above.

[Dr Stephan Havemann (Petzi1)]

Thank you Alexandro. I have corrected this.

[Alejandro Bodas (mo-abodas)]

Dr Stephan Havemann (@Petzi1) In general it all looks good, but I believe I've spotted a few inconsistencies in the units of some variables.

[iboutle]

Code looks fine to me, just one comment

[iboutle]

Changes here should be to a committed/pushed Socrates branch, rather than a working copy on your VDI

[Dr Stephan Havemann (Petzi1)]

Thank you Ian ! Of course yes. Will change that.

[Alejandro Bodas (mo-abodas)]

Thanks for the changes. It looks good. I'm not familiar with the new system, so I can't find the logs of the outputs tests, only the tick box saying that they have been completed. Do they have to be uploaded here or are they available somewhere else?