feat(solana-wallet-snap): bump solana kit v6.9 - #271
Conversation
24fe1ed to
267d297
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning MetaMask internal reviewing guidelines:
|
267d297 to
85297be
Compare
631cdca to
2aa5deb
Compare
ec834b4 to
471dac7
Compare
|
@metamaskbot publish-preview |
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
471dac7 to
79501be
Compare
|
mikesposito
left a comment
There was a problem hiding this comment.
Thanks for taking care of this bump! This PR looks mostly good, I only have comments over typecasts
| data: item.data ?? new Uint8Array(), | ||
| programAddress: | ||
| // eslint-disable-next-line @typescript-eslint/no-non-null-assertion | ||
| compiledTransactionMessage.staticAccounts[item.programAddressIndex]!, |
There was a problem hiding this comment.
Is there a scenario where this turns out to be undefined? If so, perhaps we should add an if condition and throw an error in case it is - that will also make TS happy
|
|
||
| return parseSetComputeUnitLimitInstruction( | ||
| computeUnitLimitInstruction as IInstructionWithData<Uint8Array>, | ||
| computeUnitLimitInstruction as InstructionWithData<Uint8Array>, |
There was a problem hiding this comment.
hmm, I think these casts to InstructionWithData<Uint8Array> are needed because NormalizedInput does not accept any type parameter, so NormalizedInput.instructions always use the default one. Do you think we can change NormalizedInput with a generic type so that we avoid this cast here?
| compilableTransactionMessage as TransactionMessage & | ||
| TransactionMessageWithFeePayer, |
There was a problem hiding this comment.
I was trying to figure out if this cast is necessary, and I realized that fromCompilableTransactionMessageToBase64String is only called by test files. Perhaps we should consider removing this function altogether
| ), | ||
| ], | ||
| } as CompilableTransactionMessage; | ||
| } as TTransactionMessage; |
There was a problem hiding this comment.
This cast is not ideal, but it was already there. We should consider removing it at some point.



Explanation
Upgrade Solana dependencies to @solana/kit 6.9.x, SNS SDK 1.x, and compatible Solana program packages.
Migrate transaction, instruction, signing, fee estimation, and RPC types/APIs to the new Kit interfaces.
Add support for resolving both .sns and .sol domains.
Update reverse address resolution to return .sns domains.
Update related tests, mocks, lockfile, and changelog.
Screen.Recording.2026-09-04.at.13.45.31.mov
References
Checklist