feat(tron-wallet-snap): use shareable state management lib - #295
Merged
Conversation
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
Battambang
reviewed
Sep 10, 2026
Comment on lines
202
to
204
Contributor
There was a problem hiding this comment.
Maybe the deleteKeys from the shared lib can be used there?
Contributor
Author
There was a problem hiding this comment.
Good catch, updated.
Battambang
reviewed
Sep 10, 2026
| import type { AssetEntity } from '../../entities/assets'; | ||
| import type { TronKeyringAccount } from '../../entities/keyring-account'; | ||
|
|
||
| export type AccountId = string; |
Contributor
There was a problem hiding this comment.
May worth to consider Sonar message for this raising with redundant type alias.
Contributor
Author
There was a problem hiding this comment.
Agreed, updated.
|
Battambang
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
@metamask/snap-networks-utilsstate helpers (IStateManager,State,InMemoryState) from #288.State/IStateManager/InMemoryStateimplementations and drop the now-unusedasync-mutexdependency.stateTypes.ts(UnencryptedStateValue/DEFAULT_UNENCRYPTED_STATE).context.tswithnew State({ encrypted: false, defaultState: DEFAULT_UNENCRYPTED_STATE })and type consumers asIStateManager.References
Checklist