Skip to content

fix: update minimum solana tx version to 1 - #296

Draft
mikesposito wants to merge 1 commit into
mainfrom
me/fix/update-minimum-solana-tx-version
Draft

fix: update minimum solana tx version to 1#296
mikesposito wants to merge 1 commit into
mainfrom
me/fix/update-minimum-solana-tx-version

Conversation

@mikesposito

Copy link
Copy Markdown
Member

Explanation

The snap calls getTransaction with maxSupportedTransactionVersion: 0. Once v1 transactions start appearing on-chain (today, per the Agave 4.2 rollout), the RPC node returns an error for any getTransaction call that encounters one - it won't just silently skip them.

Concretely, transaction history stops loading for any user whose history includes a v1 tx, or who interacts with a dApp that sends one. The fetchBySignature and fetchAssetsTransactions paths both throw, so the snap's activity feed goes blank or errors out.

References

N/A

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant