Skip to content

feat(snap-networks-utils): add shareable keyring account helpers - #300

Open
Julink-eth wants to merge 3 commits into
mainfrom
feat/WPN-1639-shared-keyring-account
Open

feat(snap-networks-utils): add shareable keyring account helpers#300
Julink-eth wants to merge 3 commits into
mainfrom
feat/WPN-1639-shared-keyring-account

Conversation

@Julink-eth

Copy link
Copy Markdown
Contributor

Explanation

  • Add ExtendedKeyringAccount, KeyringAccountExtension, and asStrictKeyringAccount to @metamask/snap-networks-utils.
  • The three snaps all extend @metamask/keyring-api's KeyringAccount with the same fields (entropySource, derivationPath, index) and the same strict-conversion helper (Solana/Tron asStrictKeyringAccount, Stellar #toKeyringAccount).
  • A snap may still narrow derivationPath (Stellar's BIP-44 coin type). @metamask/keyring-api@^24.1.0 is added as a type dependency so those exports compile and match the snaps.
    Not client-breaking: new helpers only.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

@Julink-eth
Julink-eth requested review from a team as code owners September 11, 2026 15:17
@Julink-eth
Julink-eth deployed to default-branch September 11, 2026 15:17 — with GitHub Actions Active
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant