Skip to content

fix(ecurrency): sync-ledger skips eNames with no eVault, adds timeouts and progress - #1202

Merged
coodos merged 1 commit into
mainfrom
fix/ecurrency-sync-unresolvable
Oct 15, 2026
Merged

coodos merged 1 commit into
mainfrom
fix/ecurrency-sync-unresolvable

Conversation

@coodos

@coodos coodos commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

Follow-up to #1201, from the first production run.

  • An eName the Registry has no eVault for (404) is reported as skipped, not a failure, so one dead account no longer fails the whole run. It also no longer burns ~30s of retries: the resolve is done outside the retry loop and a 404 is never retried.
  • Registry /resolve and /platforms/certification now time out (15s); transient Registry errors retry 3 times.
  • Every 30s the script prints how many vaults are done and which it is still working on, so a slow vault no longer looks like a hang.
  • Totals and exit code count only vaults that exist; skipped eNames are listed separately.

Tested against the eCurrency migrations on Postgres plus a mock Registry/eVault with an unresolvable eName, 429/500 faults and a dropped write: run 1 skipped the dead eName, fixed everything else and flagged the dropped write (exit 1); run 2 exited 0.

@coderabbitai

coderabbitai Bot commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: aeed751f-10d6-4002-b3c7-647c634208bf
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-15T08:51:13.962676Z cef7ee5 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coodos
coodos merged commit 399d9c8 into main Oct 15, 2026
4 checks passed
@coodos
coodos deleted the fix/ecurrency-sync-unresolvable branch October 15, 2026 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant