fix: scope Personal feed filter to personal projects only#4969
Open
aseckin wants to merge 3 commits into
Open
Conversation
The "Personal" toggle in the "My questions and posts" feed previously sent `access=private`, which matched every post whose default project had no default_permission — including private tournaments and other private projects, not just personal projects. Introduce a dedicated `personal` access value backed by a `Post.filter_personal()` manager method that filters by `default_project.type == PERSONAL_PROJECT`, and switch the frontend filter to use it. Closes #1520 Co-authored-by: Sylvain <SylvainChevalier@users.noreply.github.com>
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Collapse filter_personal()'s return to a single line and replace the three sequential access-filter if-branches with a dict dispatch so get_posts_feed stays under the C901 complexity limit. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Author
|
QA passed, pending code review @hlbmtc |
Contributor
🚀 Preview EnvironmentYour preview environment is ready!
Details
ℹ️ Preview Environment InfoIsolation:
Limitations:
Cleanup:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1520
Summary
The "Personal" toggle on the "My questions and posts" feed previously sent
access=private, which on the backend matches every post whose default project has nodefault_permission— i.e. private tournaments and other private projects as well as personal projects. Users saw non-personal private questions under the "Personal" chip.This introduces a dedicated
personalaccess value that filters strictly bydefault_project.type == PERSONAL_PROJECT, and wires the frontend "Personal" filter to it. The existingaccess=privatebehavior is unchanged.Changes
posts/serializers.py— addPERSONALtoPostFilterSerializer.Access.posts/models.py— addPost.objects.filter_personal().posts/services/feed.py— routeaccess=personalto the new filter.front_end/.../my_questions_and_posts.tsx— sendaccess=personal.Test plan
pytest).Generated with Claude Code