Repository navigation
Move session defaults into the test helper - #501
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NewSessionWithOwnersubstituted a no-op logger and a fresh registry when given nil. Its only production caller, the gateway handler, can't pass nil:NewHandlerpanics without a registry and defaults the logger. Only tests relied on the fallback, so it moves into the test helperNewSession. The one test that callsNewSessionWithOwnerdirectly now passes a no-op logger.Checks: gofmt,
go vet ./services/core/...,go test -race ./services/core/internal/runtimegateway/.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.