Repository navigation
Sync main 7bba93ae into the feature branch - #502
Merged
Merged
Conversation
* refactor(api): generate public contracts from pinned official OpenAPI * test(api): validate OpenAPI 3.1 responses and preserve package rejection * chore(api): remove unused Swagger parser dependency * fix(api): derive web search union serialization from the official schema * fix(api): preserve stored search items during public schema migration
* Delete the adapter Prepared path Every Run starts through Executor.StartTurn, and read-only preparations are served from the bound local workspace, so the adapter Prepared surface and its registered preparation factories have no production caller. Port the deletion from the agent-outside-sandbox branch with the same shape: delete agent.Prepared, PreparedCancellation, PreparationFactory, Runtime.Preparation, RegisterPreparation and ResolvePreparation, the Codex, Claude SDK and MiniMax Code preparation factories, and the Claude session's unused drain. Adapters declare WorkspaceReadPreparation beside LocalEnvironment and dispatch readies the local preparation directly. Delete the unenforced Runtime initialization network field and bump the protocol version. Delete the Codex one-shot start path (Prepared.start and Session.run), which only tests reached, and port its behaviour tests to Executor.StartTurn. Adapters no longer write the Preparation capability that registration derives. The local read-only preparation holds no resource, so delete its always-nil Close, the preparationState.prepared closer, the read-only cleanup_unconfirmed retry path and the handoff branches that executor-less preparations never reach. * Settle read-only preparation release synchronously The read-only preparation holds no resource, so its release only drops ownership. Drop it in the same state change instead of a cleanup goroutine behind the busy flag, and delete closePreparationResource and the shutdown close loop. A preparation that is still publishing its readiness keeps ownership until that returns, as before.
# Conflicts: # Makefile # apps/daemon/internal/agent/claudesdk/declaration.go # apps/daemon/internal/agent/claudesdk/preparation_test.go # apps/daemon/internal/agent/codex/declaration.go # apps/daemon/internal/agent/codex/declaration_test.go # apps/daemon/internal/agent/codex/mcp_http_preflight_test.go # apps/daemon/internal/agent/codex/mcp_required_test.go # apps/daemon/internal/agent/codex/prepared.go # apps/daemon/internal/agent/codex/prepared_test.go # apps/daemon/internal/agent/codex/recovery_test.go # apps/daemon/internal/agent/configuration_test.go # apps/daemon/internal/agent/harness.go # apps/daemon/internal/agent/mcode/declaration.go # apps/daemon/internal/agent/registry.go # apps/daemon/internal/dispatch/local_directory.go # apps/daemon/internal/dispatch/preparation.go # apps/daemon/internal/dispatch/workspace_preparation_status_test.go # contracts/agents-api/harness-onboarding.md # contracts/agents-api/zh/harness-onboarding.md # contracts/agents-api/zh/index.md # docs/runtime-protocol.md # docs/zh/development.md # docs/zh/maintainers.md # docs/zh/runtime-protocol.md
# Conflicts: # apps/daemon/internal/agent/codex/executor_native_test.go # services/core/internal/runtimegateway/session.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merges
main7bba93a intofeature/agent-outside-sandbox. It brings in #490, #495, #497, #498 (the adapter Prepared path is deleted) and #499 (the mcode opt-in and dead helpers are deleted). The wire version isproto.Version0.13.0.Conflicts were resolved toward
main's deletions, and the feature branch's assignment and Link work is kept.Local checks:
gofmtis clean.go vetpasses for the root, daemon and Core modules.make check-names check-docs check-ci check-openapi check-harness-catalogpass.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.