Repository navigation
Require the harness for a non-empty harness_config - #507
Merged
Merged
Conversation
Native parameters belong to one adapter, so validating them against whichever registered adapter accepts them was an implicit fallback. Delete the any-adapter loop: an empty kind with parameters now returns harnessconfig.ErrHarnessRequired. The resolved Agent decides: a saved Agent after the write (an update keeps the saved harness) and, for a Session, the inline agent's harness or the saved Agent's. Both reject with 400 invalid_request_error and a param that names the missing field.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A non-empty
x_agents_core.harness_confignow requires an explicitly selected Harness: the Agent'sx_agents_core.harness, or for a Session the inlineagent.x_agents_core.harnessor the saved Agent's. The deployment default does not count. Without one, the request fails with 400invalid_request_error, andparamnames the missing field.harnessconfig.Registry.ValidateHarnessConfigreturnsErrHarnessRequiredfor an empty kind. The loop that accepted the object if any registered adapter parsed it is deleted.model-execution.mdandpublic-agent-api.mdrecord the rule (en + zh).Architecture audit 30-P9 (Runtime–Harness alignment, lane R2).
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.