Skip to content

Reach the live cold continuations the way Core does #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SaladDay merged 1 commit into from
Oct 7, 2026
Merged

Reach the live cold continuations the way Core does #511

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions apps/daemon/internal/cli/claude_sdk_live_linux_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ func TestLiveRegisteredClaudeSDK(t *testing.T) {
ctx, cancel := context.WithTimeout(t.Context(), 120*time.Second)
defer cancel()
id := uuid.NewString()
request := proto.PromptRequestPayload{AgentKind: "claude_sdk", AgentStateKey: prototest.StateKey, AgentSessionID: resume, RequireExistingNativeSession: resume != "", ObserveMessages: true, DisableExecutionEnvironment: true, DisableSubagents: true, ExecutionControls: &proto.ExecutionControls{WebSearch: "disabled", TextVerbosity: "medium"}, Model: "MiniMax-M3", ModelProvider: provider}
request := proto.PromptRequestPayload{AgentKind: "claude_sdk", AgentStateKey: prototest.StateKey, AgentSessionID: resume, ObserveMessages: true, DisableExecutionEnvironment: true, DisableSubagents: true, ExecutionControls: &proto.ExecutionControls{WebSearch: "disabled", TextVerbosity: "medium"}, Model: "MiniMax-M3", ModelProvider: provider}
if callFunction {
request.FunctionTools = []proto.FunctionTool{{Name: "lookup", Description: "Return a verification value.", Parameters: json.RawMessage(`{"type":"object","properties":{"id":{"type":"string"}},"required":["id"],"additionalProperties":false}`)}}
}
Expand Down Expand Up @@ -134,8 +134,7 @@ func TestLiveRegisteredClaudeSDK(t *testing.T) {
switch status.State {
case "ready":
send(proto.TypeExecutionStart, "prepare", proto.ExecutionStartPayload{Handle: status.Handle, ExecutorID: status.ExecutorID, RunID: id, Input: proto.TextInput(prompt)})
case "started":
default:
case "rejected", "failed", "expired", "released":
t.Fatal("registered preparation failed", status)
}
continue
Expand Down
32 changes: 23 additions & 9 deletions services/core/internal/runtimegateway/mcp_bearer_live_linux_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,27 @@ func TestLiveMCPBearerGatewayColdContinuation(t *testing.T) {
if err := peer.Bind(ctx, assignment, ""); err != nil {
t.Fatal("built daemon did not bind the Session's assignment")
}
// reconnect drops the connection: the daemon's Router closes the Session's
// Executor on shutdown, so the next Run starts a fresh native process.
reconnect := func() {
t.Helper()
old := peer
old.Close("cold continuation")
for peer == old {
next, err := registry.WaitForDevice(ctx, id, 30*time.Second)
if err != nil {
t.Fatal("built daemon did not reconnect through the real gateway")
}
if next == old {
time.Sleep(50 * time.Millisecond)
continue
}
peer = next
}
if err := peer.Bind(ctx, assignment, ""); err != nil {
t.Fatal("built daemon did not bind the Session's assignment again")
}
}
run := func(prompt, resume string, expected map[string]string) *mcpBearerTurn {
t.Helper()
turn := &mcpBearerTurn{}
Expand All @@ -100,7 +121,8 @@ func TestLiveMCPBearerGatewayColdContinuation(t *testing.T) {
defer peer.Unsubscribe(runID)
control := mcpBearerStart(t, ctx, peer, assignment, request, runID, proto.TextInput(prompt))
mcpBearerCollectTurn(t, ctx, sub, runID, turn, expected, token, provider)
control.release()
peer.UnsubscribePreparation(control.id)
reconnect()
turn.NativeLaunches = mcpBearerReleased(t, root)
turn.BearerEnvironmentReference = mcpBearerConfigReference(t, root, token)
return turn
Expand Down Expand Up @@ -180,14 +202,6 @@ func (c *mcpBearerControl) await(state string) {
}
}

// release closes the Executor, so the next Run starts a fresh native process.
func (c *mcpBearerControl) release() {
c.t.Helper()
defer c.peer.UnsubscribePreparation(c.id)
c.send(proto.TypeExecutionRelease, proto.ExecutionReleasePayload{Handle: c.status.Handle})
c.await("released")
}

func mcpBearerCollectTurn(t *testing.T, ctx context.Context, sub *Subscription, runID string, turn *mcpBearerTurn, expected map[string]string, secrets ...string) {
t.Helper()
before, after := make(map[string]string), make(map[string]int)
Expand Down
Loading