Repository navigation
Require message identity on every assistant message - #524
Merged
Merged
Conversation
Every adapter now delivers each assistant message as an identified output_message start, deltas that name it, and a completed snapshot. The shared validator rejects a delta without item_id, so Core keeps one Item path: the legacy message projection, the native-message query, the observe_messages request field, the message_items capability and DonePayload.Content are deleted. MiniMax Code completes each ACP message by its native messageId when the next one starts or the Turn ends. The agent-host qualification rig binds the Session's assignment before it prepares, which execution admission requires, and reads the answer from completed message Items.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every assistant message now arrives with its identity, and Core projects message Items through one path.
output_messagewith an ID, followed bydeltas that name it and acompletedmessage carrying the full text. MiniMax Code assigns one Item per ACPmessageId; a chunk without an ID, or for a message that already ended, fails the Turn with a typed error.DeltaPayload.Validaterequiresitem_id.legacy-messagekey,LegacyFinaland itsMergeexception,NeedsNativeMessage,Stored.NativeMessage, theHasNativeMessageItemquery,PromptRequestPayload.ObserveMessages, theMessageItemscapability and the adapters' branches for it, and theDonePayload.Contentprojection. The live tests read message Items.qualify_linux_test.gobinds beforeprepare, as the runtime protocol has required since Route Environment work through one owner #510.docs/runtime-protocol.mdandharness-onboarding.mdmake message identity mandatory (+zh).proto.Versionis unchanged; the final merge bumps it once. Net −121 lines.Blind review (fresh Claude subagent): merge after fixes. Fixed: MiniMax Code rejects a resumed message ID, and the dead
AppendTextbranch initems.Mergeis gone. Deferred to R6: a Runtime frame that fails projection (a delta withoutitem_id, or an invalidoutput_message) is classified asevent_persistence_failedrather thaninvalid_executor_result. Left as is: a MiniMax Code message stays open across later tool calls until the next message or the end of the Turn, because ACP marks no message end.Checks: proto, the daemon
agent/..., dispatch and cli packages; Core items, execution, runtimegateway, sessionpg and api; the Core integration suite; darwin/windows daemon builds;node --testin the Claude SDK adapter;make check-names check-docs check-ci.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.