Repository navigation
Sync main f6656de9 into the cutover - #544
Merged
Merged
Conversation
Core owns one idle suspension policy (300 seconds idle, 86400 seconds retention) and reports it for every Provider that declares checkpoint support. The microsandbox registry constant, its copy in the provider description and the idle_seconds/retention_seconds deployment columns are deleted; migration 000094 drops the columns and rewrites runtime_deployment_setup_check without them. Registration keeps only the declared rule that checkpoint support needs a nodes registration. The API suspension shape is unchanged; its description names the declaration rule instead of a vendor.
Merge origin/main (6ce0e51) into aos/cutover. Migrations: the cutover's 000094_session_runtime_assignments.sql and 000095_sandbox_link_authority.sql become 000096 and 000097, after main's 000094 (drop runtime_deployment idle and retention columns) and 000095 (vendor-free node readiness codes). Neither cutover migration touches those columns or codes; nothing referenced the old numbers. A database that applied the old numbering must be recreated. Logic resolutions: - processconfig: main makes OAC_PUBLIC_URL, OAC_INSTALLATION_ID_FILE and OAC_CREDENTIAL_KEY_FILE required, so the cutover's "agent-host identity only with OAC_PUBLIC_URL" pairing becomes OAC_AGENT_HOST_IDENTITY_FILE required; the pairing checks are gone. tests/container_server.py mounts the identity with main's other required files. - cmd/server: main's unconditional startup (value PublicOrigin, always wired Execution and Sandboxes) now always registers the agent host and builds the Link authority and relay; Dispatcher and api.Execution get Links. managed_nodes keeps main's shape plus the cutover's sandboxLink. - api: Execution.Links joins main's value-type validate; the /api/v1/sandbox-link routes are always registered. - sessionpg: SignAttachGrant drops its nil-cipher arm, as main removed credentialcrypto.ErrUnavailable. - Integration fixtures: main's publicHandler default Execution gains Links: strict and replaces storeExecution; withPolicy stays deleted; fixtureCipher and NewModelTestStore give way to New(t, pool) and testStore(t) over pgtest.CredentialKey. Every Session still needs a model provider, so fixtureDeploymentProvider stays. - link_authority_test supplies main's required installation ID and credential key. - sessions creation_test keeps main's fingerprint failure case and the cutover's removal of the self-hosted deployment case. - Docs and Web copy keep main's removals (noAddress, credentials none, ErrUnavailable) with the cutover's Link wording; zh hashes recomputed.
TestInitialSessionInputOfficialClient and TestListQueryOfficialClientPostgres create Sessions through the official SDK. Every Session needs a model provider, so their handlers take the deployment default as the other public fixtures do. Both failed the same way on aos/cutover ac07a61; CI's acceptance job does not select them.
Merge origin/main (f6656de, #543) into aos/cutover. The only conflicts were the source_hash lines of docs/zh/configuration.md and docs/zh/sandbox-provider.md; both are recomputed from the merged English files. The cutover never edited the Docker and microsandbox node code that #543 moved (providers/docker.go, microsandbox.go, probe.go, specification.go, capacity.go, config.go), so nothing needed carrying; the cutover's Sandbox I/O bootstrap in docker/provider.go and docker/bootstrap.go and its Bootstrap.Validate in sandbox_provider.go sit beside #543's NodeConfig, LocalOptions and Built. No migration or generated projection changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync 6: merges
main6ce0e51 and then f6656de into the cutover. Lanes:I (Derive idle suspension from the checkpoint declaration #538), idle and retention as Core constants;
I2 (Read Provider declarations in Web #539), Provider declarations in Web;
K (Classify node readiness without vendor codes #540), vendor-free readiness classes;
G (Require the installation ID and credential key #541), required installation ID, credential key and public URL;
J (Keep vendor node settings in the adapter #543), vendor node settings in the adapters;
Align the setting categories in AGENTS.md #514 and Align Web design notes with Provider declarations #542.
Migrations: the aos migrations become
000096_session_runtime_assignmentsand000097_sandbox_link_authority, unchanged otherwise, above main's 000094 and 000095. A database migrated with the old aos numbering must be recreated.Process settings: with G's required
OAC_PUBLIC_URL,OAC_AGENT_HOST_IDENTITY_FILEis always required too. The agent host is always registered, and the Link relay is always built and wired. Every launcher that sets the credential key also sets the identity.Test fixtures: they move to G's
pgtest.CredentialKey.fixtureCipherandNewModelTestStoreare gone. The two official-client Go tests that G's CI ordering now runs get a model provider; they already failed on the cutover.Docs:
sandbox-provider.mdno longer saysRequirementsdeclares a public Core origin.Generators: sqlc,
make openapi, the specification contract and the provider artifacts all report no diff.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.