Repository navigation
Settle the agent-host placement review findings - #552
Merged
Merged
Conversation
An idle pass consults the assignment only to quiesce, so an unplaced Session or a disconnected agent host is not recorded as a sandbox fault. The initialization scanner places a Session only on a host that advertises its Harness as available, as the Turn path does. waitServing returns a shutdown's own error and leaves the pass time to resume. TestInitializationBindsAgentHost uses a configured deployment, which hosted admission now requires.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes from the blind review of #550, and the CI failure of #551.
runtime_compute.go): the pass keeps the allocation and handles a wake request before it looks at the assignment, which it needs only to quiesce. An unplaced Session has nothing to quiesce, and a disconnected agent host is retried later; neither is recorded asprovider_unavailableany more.runtime_initialization.go): the scanner places a Session only on a host that advertises its Harness as available (runtimeDeclaration), the predicate the Turn path already uses. A host without the Harness no longer gets the Session pinned and failed withProvisioningHarness; with no such host, the initialization waits like a queued Turn.runtime_compute_wake.go):waitServingwaits at most 20 of the pass's 30 seconds, leaving time to resume the Environment, and returns the parent's error on shutdown or lease loss instead ofErrComputeUnconfirmed.TestInitializationBindsAgentHostcreates a hosted Session, whichmain's configured admission (Admit hosted work only on a configured deployment #546) admits only on a configured deployment; it now usesconfiguredStore.Checks:
go build ./...;go vetand unit tests ofexecution; integration tests for compute lifecycle, suspension, idle clock, initialization, placement, the local Environment worker, Link authority and agent host (the new unplaced-observation assertion fails without the idle fix);make check-names check-docs check-ci.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.