Repository navigation
fix(e2b): accept nullable sandbox information domains - #600
Merged
SaladDay merged 1 commit intoOct 8, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
E2B SDK information responses can omit the sandbox domain. The provider treated these valid responses as ownership failures, rejecting provisioning before bootstrap and preventing cleanup from reaching Kill. Accept the SDK’s nullable information field while retaining metadata, template and resource checks.
Create connection destinations remain strictly validated, and restoring saved connection material validates its destination before any envd request. Information responses never supply connection material.
Validation: 5 template tests, 222 helper tests, the generated helper contract, and Go E2B adapter tests pass. Regressions use the pinned SDK model conversion and cover lifecycle, nullable/omitted domains, foreign destinations, uncertain Create and saved-connection recovery. Negative controls reproduce both the original failure and the unsafe recovery behavior without the guard.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.