Repository navigation
test(claude): compare execution controls at one deadline - #601
Merged
SaladDay merged 1 commit intoOct 8, 2026
Merged
Conversation
SaladDay
deleted the
aos/fix-claude-execution-control-comparison-deadline
branch
October 8, 2026 23:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The execution-control equivalence test built two requests from separate clock samples. Since the preparation deadline is now part of the native request, crossing a millisecond made the full comparison fail even when execution controls preserved every default.
Give both compared requests the same preparation deadline and retain the complete equality and input-immutability assertions. Production behavior is unchanged.
Validation: the original failure was reproduced with a deterministic 2 ms separation between clock samples; the corrected test passes under the same condition with race detection for 100 repetitions. The complete Claude SDK adapter package also passes.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.