Repository navigation
Reduce manifest read round trips - #605
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Environment preparation looked up an existing installation manifest twice before reading it. Reuse the file reference acquired by the first lookup, saving one File RPC per snapshot read. A newly finalized installation still performs a fresh lookup. File type, size, read-only mode, manifest selection, error handling and reference cleanup remain enforced; no cross-operation cache or protocol change is introduced.
Validation: 13 manifest boundary cases, 126 related tests and race repetitions (50) passed; six existing privileged-view prerequisite tests were skipped. Build, vet and naming/documentation/CI hygiene passed. Coordinator reviewed the complete diff and corrected an oversized-file test so read-only validation cannot mask the size guard.
The real File service/client benchmark confirms Lookup count 2 → 1 at injected per-RPC delays of 0/1/20/100 ms. This saves one round trip; it does not establish live Session or native startup speedup. Same-source live qualification follows integration.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.