Repository navigation
Contain sandbox process descendants in delegated cgroups - #614
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sandbox process cancellation now contains descendants that fork, double-fork or call
setsidwhen the existingScopeCgroupV2capability is selected. SandboxIO verifies delegation, creates an operation subgroup, and places its trusted trampoline there before target execution. Cancellation kills that subtree and confirms kernel emptiness independently of leader exit and output drain; failed kills continue retrying even while the leader remains alive.The implementation reuses the process protocol, launch gate, reaper and scope observer. It adds no dependency or public field. Normal background work survives leader exit, and unsupported delegation remains an explicit capability distinction. The existing backend runtime CI job now exercises real delegated cgroups with missing support treated as a failure; the owning English and Chinese documentation is updated.
Validation: real delegated full-package race tests, repeated cancellation/signal/cgroup race tests, focused SandboxIO/process-contract tests, build/vet, naming/docs/CI checks and translation checks. Provider delegation and public stdio cancellation settlement are integrated separately.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.