Skip to content

fix(web): dismiss tooltips before dialogs on Escape - #620

Open
dvd233 wants to merge 1 commit into
MiniMax-AI:mainfrom
dvd233:codex/fix-help-tooltip-escape
Open

dvd233 wants to merge 1 commit into
MiniMax-AI:mainfrom
dvd233:codex/fix-help-tooltip-escape

Conversation

@dvd233

@dvd233 dvd233 commented Oct 9, 2026 •

Copy link
Copy Markdown

In Edit node, pressing Escape while a field's help tip is open also closes the dialog and discards unsaved edits. This happens after keyboard focus or clicking the help button, and when the tip is only hovered while the name field keeps focus.

Handle Escape during the tip's visible lifetime, before the enclosing dialog receives it. Dismissing the tip preserves the current field values and focus; the next Escape still closes the dialog and restores focus to its opener. Add console acceptance coverage for all three ways of opening the tip and verify that cancellation sends no management writes.

Validation:

  • Reproduced the dialog closing unexpectedly before the fix; all three new Chrome acceptance cases pass after the fix.
  • Existing node editing and rollout-dialog Escape acceptance cases pass.
  • Web/client typecheck, 712 client tests, and the production Web build pass.
  • Full Web unit run on Windows: 367 passed, 14 failed in the unchanged POSIX installer-command tests because sh was not on PATH. Retrying that file with the existing Git shell and an isolated fixture home gives 5 passed and 10 failed; a focused diagnostic identifies MSYS-to-Windows path conversion in the checksum fixture. No tests or assertions were changed to bypass these failures.

The browser checks use the repository's local console fixture. They do not exercise a live Core deployment or model provider.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant