Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Edit node, pressing Escape while a field's help tip is open also closes the dialog and discards unsaved edits. This happens after keyboard focus or clicking the help button, and when the tip is only hovered while the name field keeps focus.
Handle Escape during the tip's visible lifetime, before the enclosing dialog receives it. Dismissing the tip preserves the current field values and focus; the next Escape still closes the dialog and restores focus to its opener. Add console acceptance coverage for all three ways of opening the tip and verify that cancellation sends no management writes.
Validation:
shwas not on PATH. Retrying that file with the existing Git shell and an isolated fixture home gives 5 passed and 10 failed; a focused diagnostic identifies MSYS-to-Windows path conversion in the checksum fixture. No tests or assertions were changed to bypass these failures.The browser checks use the repository's local console fixture. They do not exercise a live Core deployment or model provider.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.