Repository navigation
Conversation
sam2tom
marked this pull request as ready for review
September 24, 2026 15:08
Collaborator
Author
|
Closed by product decision. Future Core Console work follows #96; this standalone change is no longer needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Machine management now distinguishes a failed console capability request from an explicitly unconfigured deployment and presents both in the existing console layout with a refresh action.
When the console is opened through a localhost SSH tunnel, Add node requires a non-loopback HTTPS address for the same console before issuing an enrollment token. Commands retain the deployment Core origin separately; an unusable Core origin is reported instead of generating a command. Normal HTTPS console access retains the one-click flow. Enrollment secrets remain transient and late responses are discarded after closing or changing connections.
Validation: TypeScript checks and Web production build passed; 409 client and 781 Web unit tests passed; 33 focused sandbox manager/setup browser tests passed.
make checkpassed Console and installer/distribution checks, then stopped becausePARSAR_AGENTS_API_TEST_DATABASE_URLwas not set. No real node registration or deletion was performed. Independent blind review found no blocking issues; the reviewer also passed five focused browser regressions.Deployments still need paired server-side administrator credentials and a matching node distribution payload served at
/node-install/. The console URL used by the target host must actually serve that payload; an API-only origin is insufficient.