Repository navigation
fix(plugin): serve the plugin from the release branch, moved only after npm publish - #125
Merged
Merged
Conversation
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The marketplace entry
"source": "./plugins/bpmn-cli"resolves against the marketplace clone, which is the tip ofmain. A fresh install can therefore get a skill ahead of its CLI (as between #15 and 0.5.0), or one that pins annpxversion npm does not have yet (between the release PR merge andnpm publish). A copy installed in such a window carries the release's version string, soclaude plugin updatekeeps it until the next release.What
marketplace.json: the plugin comes from agit-subdirsource onhttps://github.com/Miragon/bpmn-cli.git, pathplugins/bpmn-cli,ref: release. The plugin id staysbpmn-cli@miragon-bpmn, so existing installs update without a reinstall.release-please.yml: new jobplugin-release-branch, afterpublish. It fast-forwardsreleaseto the release tag through the GitHub API (force=false);contents: writeis scoped to this job.docs/releasing.md: the new step, why the branch exists, and how to recover from a failed move.test/e2e/plugin.test.ts: checks the new entry and that itspathholds the plugin.releasealready exists atv0.8.0(created through the API), so the entry resolves from the moment this is merged.Verification
claude plugin validate --strict .andplugins/bpmn-clipass.vitest run test/e2e/plugin.test.ts -t "plugin metadata"passes.CLAUDE_CONFIG_DIR: installsbpmn-cli@miragon-bpmn0.8.0 fromrelease.release: the same sha succeeds; moving it back tov0.7.0is refused with422 Update is not a fast forward.Closes #19 together with #124.